Enhance BoardGameModel and BoardGameGeekAPI: Add age, boardgame famil… #216
Conversation
…ies, boardgame mechanics, awards, description, language dependence, best with players, recommended with players
| const publishers = Array.from(boardgame.querySelectorAll('boardgamepublisher')) | ||
| .map(n => n.textContent) | ||
| .filter(n => n !== null); | ||
| const boardGameFamilies = Array.from(boardgame.querySelectorAll('boardgamefamily')) |
There was a problem hiding this comment.
This seems to include some not very relevant categories for some games.
| const minPlayers = Number.parseFloat(boardgame.querySelector('minplayers')?.textContent ?? '0'); | ||
| const maxPlayers = Number.parseFloat(boardgame.querySelector('maxplayers')?.textContent ?? '0'); | ||
| const playtime = (boardgame.querySelector('playingtime')?.textContent ?? 'unknown') + ' minutes'; | ||
| const age = Number.parseFloat(boardgame.querySelector('age')?.textContent ?? '0'); |
There was a problem hiding this comment.
age is a quite generic term. Is this the recommended age, or the minimum age to play?
|
|
||
| const bestWithPlayers = | ||
| response.querySelector('poll-summary[name=suggested_numplayers] result[name=bestwith]')?.attributes.getNamedItem('value')?.value ?? ''; | ||
| const recommendedWithPlayers = |
There was a problem hiding this comment.
I think only including one of those two would be better, as we already have min and max players.
There was a problem hiding this comment.
I vote for including both min and max and bestWithPlayers. The bestWithPlayers data is extremely valuable for figuring out what player counts actually play well. A significant number of 2 to 4,5,6 player games are actually pretty bad at 2 players and bestWithPlayers gives this data.
| playtime: string; | ||
| age: number; | ||
| publishers: string[]; | ||
| boardGameFamilies?: string[]; |
There was a problem hiding this comment.
I think the new properties could be better sorted. E.g. all the player counts together.
3 participants
…ies, boardgame mechanics, awards, description, language dependence, best with players, recommended with players