test #44
test #44
Conversation
Шрифт и иконка
Ссылки в главное меню и выпадающий список
Added tooltips and titles ( пока что без мультиязычности, но при наведении на иконки и в выпадающем списке при наведении всё видно)
Bumps the npm_and_yarn group with 1 update in the / directory: [vite-plugin-static-copy](https://github.com/sapphi-red/vite-plugin-static-copy). Updates `vite-plugin-static-copy` from 3.1.0 to 3.1.2 - [Release notes](https://github.com/sapphi-red/vite-plugin-static-copy/releases) - [Changelog](https://github.com/sapphi-red/vite-plugin-static-copy/blob/main/CHANGELOG.md) - [Commits](https://github.com/sapphi-red/vite-plugin-static-copy/compare/[email protected]@3.1.2) --- updated-dependencies: - dependency-name: vite-plugin-static-copy dependency-version: 3.1.2 dependency-type: direct:development dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <[email protected]>
…_yarn-d42c96e7b6 Bump vite-plugin-static-copy from 3.1.0 to 3.1.2 in the npm_and_yarn group across 1 directory
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a complete migration from Jekyll to SvelteKit for the mRemoteNG website, creating a modern web application with internationalization (i18n), theme switching, and responsive design. The changes transform the static Jekyll site into a dynamic SvelteKit application with enhanced user experience features.
Key changes:
- Complete SvelteKit application setup with TypeScript support and static adapter
- Implementation of i18n support for multiple languages (English, Russian, German)
- Addition of theme switching functionality with dark/light mode support
- Bootstrap-based responsive UI with modern component structure
Reviewed Changes
Copilot reviewed 67 out of 116 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | SvelteKit project configuration with dependencies for UI framework and build tools |
| vite.config.ts | Vite configuration with TailwindCSS and SvelteKit plugins |
| svelte.config.js | SvelteKit configuration for static site generation and GitHub Pages deployment |
| src/routes/+layout.svelte | Main layout component with header, footer, and global styles |
| src/lib/components/*.svelte | Reusable UI components for header, footer, theme switcher, and language switcher |
| src/lib/i18n/*.ts/.json | Internationalization implementation with translation files |
| src/lib/stores/theme.js | Theme management store for dark/light mode switching |
| static/* | Static assets including CSS, JavaScript, icons, and favicon files |
Comments suppressed due to low confidence (1)
static/js/theme-loader.js:1
- Dead code should be removed instead of being commented out. This commented block serves no purpose and clutters the codebase.
(function() {
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| plugins: [tailwindcss(), sveltekit()] | ||
|
|
There was a problem hiding this comment.
There is trailing whitespace on line 7. Remove the extra space to maintain consistent code formatting.
| plugins: [tailwindcss(), sveltekit()] | |
| @@ -0,0 +1,32 @@ | |||
| import { writable } from 'svelte/store'; | |||
|
|
|||
| // Функция для безопасного доступа к localStorage | |||
There was a problem hiding this comment.
Comments are written in Russian but should be in English for consistency with the rest of the codebase and to ensure all team members can understand the code.
| }); | ||
| } | ||
|
|
||
| // Инициализация только на клиенте |
There was a problem hiding this comment.
Comments are written in Russian but should be in English for consistency with the rest of the codebase and to ensure all team members can understand the code.
| // Инициализация только на клиенте | |
| // Initialization only on the client |
| <!-- Right side of the navbar --> | ||
| <ul class="navbar-nav ms-md-auto"> | ||
| <li class="nav-item"> | ||
| <a rel="noopener" class="nav-link" href="{base}/downloads" title= "Donwloads"> |
There was a problem hiding this comment.
There's a typo in the title attribute: 'Donwloads' should be 'Downloads'.
| <a rel="noopener" class="nav-link" href="{base}/downloads" title= "Donwloads"> | |
| <a rel="noopener" class="nav-link" href="{base}/downloads" title="Downloads"> |
| font-family: 'HandelGotDBol', sans-serif; | ||
| background: #f0f0f0; | ||
| font-family: 'Open Sans', sans-serif; |
There was a problem hiding this comment.
The font-family property is declared twice on consecutive lines with different values. The second declaration will override the first, making line 14 ineffective.
| font-family: 'HandelGotDBol', sans-serif; | |
| background: #f0f0f0; | |
| font-family: 'Open Sans', sans-serif; | |
| font-family: 'Open Sans', sans-serif; | |
| background: #f0f0f0; |
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: