Crash Error instances without processing them

[konker]

This PR allows instances of errors to pass-through the crash helper untouched.
This removes a layer of processing when the error case is already an Error instance.

Additionally, some fixes were made to incorrect async usage of jest resolves/rejects statements.
E.g.

it('should work', () => {
    expect(ruins.fromTaskOption(...)).resolves.toBe(...);
}

Changed to:

it('should work', async () => {
    await expect(ruins.fromTaskOption(...)).resolves.toBe(...);
}

This uncovered a broken test for task-option, which was also fixed.

[cyberixae]

The way ruins throws errors at the moment is clearly not ideal. I think there are two competing goals here. One is throwing the error type E as accurately as possible. This seems particularly useful for situations where the type E has been purposefully designed to be thrown. The other one is wrapping E into a RuinsError that makes sure the exception has a proper stack trace and remains distinguishable with instanceof in situations where the type E has not been purposefully designed with throwing in mind. In the latter case, I think it would be nice if the original error E was somehow recoverable from a RuinsError.

Ruins was originally developed for use in situations where the type E has not been purposefully been designed for use with Ruins. However, I do see some value in the ability to create interfaces purposefully design to interact in a certain way when used together with Ruins. I am wondering whether or not a separate fromEitherError function would make sense. It could limit input values to Either<Error, T> values that have should already be suitable for throwing.

Whether or not Ruins should have special support for values specifically handcrafted with Ruins in mind is debatable. Perhaps a separate package could be created for utilities that require the input types to be crafted in a certain way. I feel like there is a slight difference even though both use cases are part of the same puzzle.

[cyberixae]

Should we close this?