added rendering hints to help with pixel art scaling#30
Open
rachel-mp4 wants to merge 1 commit intomac-comp127:mainfrom
Open
added rendering hints to help with pixel art scaling#30rachel-mp4 wants to merge 1 commit intomac-comp127:mainfrom
rachel-mp4 wants to merge 1 commit intomac-comp127:mainfrom
Conversation
Contributor
|
Yes, I think it's reasonable to support nearest neighbor interpolation for pixel art projects. Makes sense! You mentioned that this is for scaling up. Did you only need this for images? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nearest neighbor interpolation is about 10x faster and looks much better than the default bilinear interpolation when scaling up pixel art, so I added a method on GraphicsObjects that allows you to set the mode. RenderingHints also allows for bicubic interpolation so I added that too, but personally I can't tell the difference and its about 10x slower than bilinear interpolation so I'd be okay with not including it, because it could end up being more trouble than its worth if someone abuses it. Then this method could accept a boolean instead of a string. But all I can say is my group would've really appreciated having nearest interpolation for our 127 final project because it felt unnecessarily challenging to work around, and I think it would be cool to introduce students to tradeoffs in rendering because woah graphics how do computers count so fast