-
Notifications
You must be signed in to change notification settings - Fork 4
feat: add Azure Key Vault provider support with GitHub workflow inputs #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
18
commits into
main
Choose a base branch
from
copilot/add-azure-key-vault-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Co-authored-by: macalbert <[email protected]>
Co-authored-by: macalbert <[email protected]>
Co-authored-by: macalbert <[email protected]>
Co-authored-by: macalbert <[email protected]>
Copilot
AI
changed the title
[WIP] Add Azure Key Vault integration with tests
Add Azure Key Vault provider support
Nov 14, 2025
Co-authored-by: macalbert <[email protected]>
Co-authored-by: macalbert <[email protected]>
Copilot
AI
changed the title
Add Azure Key Vault provider support
feat: add Azure Key Vault provider support
Nov 15, 2025
- Enhance README to include Azure Key Vault support alongside AWS. - Create detailed Azure Key Vault setup guide for Envilder.
Co-authored-by: macalbert <[email protected]>
Copilot
AI
changed the title
feat: add Azure Key Vault provider support
feat: add Azure Key Vault provider support with GitHub workflow inputs
Nov 16, 2025
Co-authored-by: macalbert <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What does this PR do?
Adds Azure Key Vault as a cloud provider alongside AWS SSM, maintaining backward compatibility with AWS as the default. This implementation was built from scratch with a clean architecture and has been merged with the latest main branch changes.
Core Changes:
--providerCLI flag (defaults toaws)AzureKeyVaultSecretProviderimplementingISecretProviderinterface following the same dependency injection pattern as AWSAZURE_KEY_VAULT_URLmap_file,env_file, andprovideroptionsGitHub Workflow Enhancements:
Added workflow_dispatch inputs to
.github/workflows/tests.yml:map_file: Path to the JSON file with environment variable mapping (default: param-map.json)env_file: Path to the .env file to be generated or imported (default: .env)provider: Cloud provider choice dropdown (aws/azure, default: aws)Implementation:
Secret paths like
/my-app/db/passwordare automatically normalized tomy-app-db-passwordfor Azure compatibility.Architecture Consistency:
Both providers follow the same dependency injection pattern for consistency:
AwsSsmSecretProvider(ssm: SSM)- Accepts pre-constructed SSM clientAzureKeyVaultSecretProvider(client: SecretClient)- Accepts pre-constructed SecretClientThis provides better testability, more flexibility for credential configuration, and consistent architecture across providers.
Main Branch Integration:
Related issues
Implements requested feature for Azure Key Vault support.
Type of change
Checklist
Notes for reviewer
Startup.configureInfrastructure()SecretClientdirectly (matching AWSSSMpattern) for consistency and better testabilityOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.