Increase precision of age around birthdate#19
Open
theycallmeswift wants to merge 1 commit intomaccman:masterfrom
Open
Increase precision of age around birthdate#19theycallmeswift wants to merge 1 commit intomaccman:masterfrom
theycallmeswift wants to merge 1 commit intomaccman:masterfrom
Conversation
- Convert the dob to the current timezone when saving and loading - Calculate age in years by comparing days - Calculate age in MS as % of MS in current year
|
It would be great if this could be merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current formula for calculating age isn't accurate within ~24 hours of the birthday on some years because we're using a hardcoded value for milliseconds per year. This change calculates the year and decimal places separately to increase accuracy.
Changes: