Skip to content

Conversation

@dlorenc
Copy link
Collaborator

@dlorenc dlorenc commented Jun 29, 2017

I'm still not completely happy with this code, but I wanted to send it out early and see what you thought @zchee.

@zchee
Copy link
Member

zchee commented Jun 29, 2017

@dlorenc Thanks. I know iso9660 package (but was not digging), it's make sense.
Some users waiting to release the new version and pre-build binary. I'll check that package and test this pull request after the release new version. #182

@zchee
Copy link
Member

zchee commented Jun 29, 2017

@dlorenc

I'm still not completely happy with this code

OK, I'll wait for the complete code.
Could you rebase to master(for now)? Maybe CI test is successful.

@zchee
Copy link
Member

zchee commented Jun 29, 2017

and, /cc @praveenkumar because he wrote the related code.

@praveenkumar
Copy link
Collaborator

Thanks for notification, I will go through it and test.

@praveenkumar
Copy link
Collaborator

Tested this PR with CentOS/b2d iso and it able to extract kernel options as expected. 👍

@zchee
Copy link
Member

zchee commented Jul 13, 2017

@dlorenc This PR and #189, Which is a priority?

@dlorenc
Copy link
Collaborator Author

dlorenc commented Jul 13, 2017

#189, I'll rebase this one after :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants