Conversation
f96e706 to
9ac77dd
Compare
9ac77dd to
5dab1d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/coding-guidelines.md#component-naming
Following this convention, we make our
mackerelotlpexporter callable under the type namemackerel_otlp. The old type namemackerelotlpwill be retained as an alias and made available for a certain period.The issue where warning messages appear when using the default settings for the OpenTelemetry Collector Mackerel will be addressed in a separate pull request (#106).
Test
In the default config of the Mackerel OpenTelemetry Collector, legacy component names (used as aliases) are still used, but they continue to work. The only difference is that a warning message is displayed.