Skip to content

Conversation

@GroovinChip
Copy link
Collaborator

@GroovinChip GroovinChip commented Sep 29, 2025

This PR takes care of some minor housekeeping:

  • Support Dart 3.9.2
  • Bump dependencies & add required new direct dependency vector_math
  • Address lints & migrate away from the deprecated scale() function to scaleByVector3() & according increase minimum supported Flutter version to match

Pre-launch Checklist

  • I have incremented the package version as appropriate and updated CHANGELOG.md with my changes
  • I have added/updated relevant documentation
  • I have run "optimize/organize imports" on all changed files
  • I have addressed all analyzer warnings as best I could

@Adrian-Samoticha
Copy link
Member

I get this when trying to run the project with Flutter 3.35.5:

All plugins found for macos are Swift Packages, but your project still has CocoaPods integration. Your
project uses a non-standard Podfile and will need to be migrated to Swift Package Manager manually. Some
steps you may need to complete include:
  * In the macos/ directory run "pod deintegrate"
  * Transition any Pod dependencies to Swift Package equivalents. See
  https://developer.apple.com/documentation/xcode/adding-package-dependencies-to-your-app
  * Transition any custom logic
  * Remove the include to "Pods/Target Support Files/Pods-Runner/Pods-Runner.debug.xcconfig" in your
  macos/Flutter/Flutter-Debug.xcconfig
  * Remove the include to "Pods/Target Support Files/Pods-Runner/Pods-Runner.release.xcconfig" in your
  macos/Flutter/Flutter-Release.xcconfig

Removing CocoaPods integration will improve the project's build time.
Launching lib/main.dart on macOS in debug mode...
Warning: CocoaPods is installed but broken. Skipping pod install.
  You appear to have CocoaPods installed but it is not working.
  This can happen if the version of Ruby that CocoaPods was installed with is different from the one being
  used to invoke it.
  This can usually be fixed by re-installing CocoaPods.
For re-installation instructions, see https://guides.cocoapods.org/using/getting-started.html#installation



Error: CocoaPods not installed or not in valid state.

This is after enabling SPM with the following command:

flutter config --enable-swift-package-manager

I would have guessed Cocoapods’ state wouldn’t matter if I’m using SPM. Note that #573 adds support for SPM, so I’m not sure what’s causing the issue. Does the same thing happen on your machine @GroovinChip?

@GroovinChip
Copy link
Collaborator Author

This does not occur for me @Adrian-Samoticha

@GroovinChip GroovinChip requested a review from Copilot October 6, 2025 13:40
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Housekeeping update to support newer Dart SDK (3.9.2), refresh dependencies (adding vector_math), address lints, and migrate deprecated Matrix4.scale usages to scaleByVector3. Test expectations updated to reflect new Color/MacosColor debug string formats and CI workflow consolidated (integrated DCM into main analysis workflow).

  • Update SDK constraints and dependency versions; add vector_math.
  • Migrate scale() -> scaleByVector3() and apply lint-driven formatting changes.
  • Adjust tests for new color string representations; integrate DCM into existing workflow and remove separate workflow file.

Reviewed Changes

Copilot reviewed 22 out of 25 changed files in this pull request and generated 12 comments.

Show a summary per file
File Description
pubspec.yaml Bumps package version, SDK constraint, dependencies, adds vector_math.
CHANGELOG.md Documents new patch release and housekeeping notes.
lib/macos_ui.dart Alters library directive (potential syntax issue).
lib/src/icon/macos_icon.dart Adds vector_math import, migrates to scaleByVector3, formatting tweaks.
lib/src/buttons/checkbox.dart Minor refactors, explicit return type, CupertinoColors -> MacosColors.
lib/src/layout/tab_view/tab_view.dart Adds lint suppression comment for doc HTML.
Test files (multiple) Update expected debugFillProperties output and color constants.
example/ (multiple files) Removes unused import, refactors builder parameter names (introduces duplicate identifier issue).
.github/workflows/flutter_analysis.yml Integrates DCM steps into main analysis workflow.
.github/workflows/dart_code_metrics.yaml Removes standalone DCM workflow.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@GroovinChip GroovinChip merged commit 6e85c0f into dev Oct 13, 2025
2 of 4 checks passed
@GroovinChip GroovinChip deleted the housekeeping branch October 13, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants