-
-
Notifications
You must be signed in to change notification settings - Fork 200
chore: Housekeeping #580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Housekeeping #580
Conversation
Requires a new direct dependency on `pkg:vector_math`
|
I get this when trying to run the project with Flutter 3.35.5: This is after enabling SPM with the following command: I would have guessed Cocoapods’ state wouldn’t matter if I’m using SPM. Note that #573 adds support for SPM, so I’m not sure what’s causing the issue. Does the same thing happen on your machine @GroovinChip? |
|
This does not occur for me @Adrian-Samoticha |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Housekeeping update to support newer Dart SDK (3.9.2), refresh dependencies (adding vector_math), address lints, and migrate deprecated Matrix4.scale usages to scaleByVector3. Test expectations updated to reflect new Color/MacosColor debug string formats and CI workflow consolidated (integrated DCM into main analysis workflow).
- Update SDK constraints and dependency versions; add vector_math.
- Migrate scale() -> scaleByVector3() and apply lint-driven formatting changes.
- Adjust tests for new color string representations; integrate DCM into existing workflow and remove separate workflow file.
Reviewed Changes
Copilot reviewed 22 out of 25 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| pubspec.yaml | Bumps package version, SDK constraint, dependencies, adds vector_math. |
| CHANGELOG.md | Documents new patch release and housekeeping notes. |
| lib/macos_ui.dart | Alters library directive (potential syntax issue). |
| lib/src/icon/macos_icon.dart | Adds vector_math import, migrates to scaleByVector3, formatting tweaks. |
| lib/src/buttons/checkbox.dart | Minor refactors, explicit return type, CupertinoColors -> MacosColors. |
| lib/src/layout/tab_view/tab_view.dart | Adds lint suppression comment for doc HTML. |
| Test files (multiple) | Update expected debugFillProperties output and color constants. |
| example/ (multiple files) | Removes unused import, refactors builder parameter names (introduces duplicate identifier issue). |
| .github/workflows/flutter_analysis.yml | Integrates DCM steps into main analysis workflow. |
| .github/workflows/dart_code_metrics.yaml | Removes standalone DCM workflow. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This PR takes care of some minor housekeeping:
vector_mathscale()function toscaleByVector3()& according increase minimum supported Flutter version to matchPre-launch Checklist
CHANGELOG.mdwith my changes