Skip to content

Comments

Remove patches and patchMad.sh#1040

Closed
Qubitol wants to merge 9 commits intomadgraph5:masterfrom
Qubitol:nopatch
Closed

Remove patches and patchMad.sh#1040
Qubitol wants to merge 9 commits intomadgraph5:masterfrom
Qubitol:nopatch

Conversation

@Qubitol
Copy link
Collaborator

@Qubitol Qubitol commented Aug 19, 2025

Implement the patches already in the code:

  • either already in upstream code (for driver.f and matrix file);
  • or in CUDACPP code (for makefile).

For the makefile in particular, I used an overlay approach, in which I put the patches inside an additional cudacpp_overlay.mk file, and modified the compilation commands in this way:

make -f makefile -f cudacpp_overlay.mk ...

so that the second file imported would override any recipe defined in makefile.

See also related mg5amcnlo#191.

@Qubitol
Copy link
Collaborator Author

Qubitol commented Sep 26, 2025

Instead of implementing the additions in upstream, use code generation and string placeholders in iolibs/template_files/madevent_driver.f, so that the changes are managed by the plugin itself, through overriding of write_driver in FortranExporterBridge.
Placeholders are called: CUDACPP_EXTRA_HEADER, CUDACPP_EXTRA_INITIALISE, CUDACPP_EXTRA_FINALISE.

@Qubitol Qubitol closed this Oct 14, 2025
Qubitol added a commit to Qubitol/madgraph4gpu that referenced this pull request Oct 14, 2025
This solves the issues presented in madgraph5#1040, madgraph5#1045, madgraph5#1048, madgraph5#1051: apparently,
googletest is build once and then cached: if it had been built on an
Intel runner with AVX512 support, and the same is restored on an AMD
runner without AVX512, then the runTest.exe would fail with Illegal
Instruction.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant