Closed
Conversation
Collaborator
Author
|
Instead of implementing the additions in upstream, use code generation and string placeholders in |
19072fa to
56b393e
Compare
…ATA VECSIZE_USED initialisation
Qubitol
added a commit
to Qubitol/madgraph4gpu
that referenced
this pull request
Oct 14, 2025
This solves the issues presented in madgraph5#1040, madgraph5#1045, madgraph5#1048, madgraph5#1051: apparently, googletest is build once and then cached: if it had been built on an Intel runner with AVX512 support, and the same is restored on an AMD runner without AVX512, then the runTest.exe would fail with Illegal Instruction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the patches already in the code:
driver.fand matrix file);makefile).For the
makefilein particular, I used an overlay approach, in which I put the patches inside an additionalcudacpp_overlay.mkfile, and modified the compilation commands in this way:so that the second file imported would override any recipe defined in
makefile.See also related mg5amcnlo#191.