feat: add support for splitting TcpStream and UnixStream#251
Open
teskje wants to merge 2 commits intomadsim-rs:mainfrom
Open
feat: add support for splitting TcpStream and UnixStream#251teskje wants to merge 2 commits intomadsim-rs:mainfrom
TcpStream and UnixStream#251teskje wants to merge 2 commits intomadsim-rs:mainfrom
Conversation
46c9905 to
8e4fcce
Compare
Contributor
Using a spin lock here looks acceptable to me, as there appears to be no contention and it's just used for working around the borrow checker. However, I'm still wondering if it's inevitable. Ideally the reader and the sender operates on different field of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the missing
TcpStream::{into_}splitandUnixStream::{into_}splitAPIs, as a step towards tokio parity.UnixStreamis currently just a mock type, so the new read/write half types are as well.TcpStreamhas full support. Unfortunately, to support the borrowedReadHalf/WriteHalftypes, I had to makeTcpStreaminterior-mutable by wrapping some of its fields intoMutexs. The resulting need for locking is a bit annoying. Lmk if anyone has a better idea!