chore: bump tonic to 0.13 and etcd-client to 0.16#255
Closed
chore: bump tonic to 0.13 and etcd-client to 0.16#255
0.13 and etcd-client to 0.16#255Conversation
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
There was a problem hiding this comment.
Pull request overview
This PR bumps tonic from version 0.12 to 0.13 and etcd-client from version 0.14 to 0.16. The update aligns the simulator with the current ecosystem, as noted in the PR description, many crates are still on tonic 0.13 despite 0.14 being available.
Changes:
- Updated tonic and tonic-build dependencies from 0.12 to 0.13
- Updated etcd-client dependency from 0.14 to 0.16
- Refactored TLS feature flags to match tonic 0.13's granular feature set (tls-native-roots, tls-webpki-roots, tls-ring, tls-aws-lc)
- Added new API methods to Server and Endpoint to maintain compatibility with tonic 0.13
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| madsim-tonic/Cargo.toml | Version bump to 0.6.0+0.13, updated tonic to 0.13, tower to 0.5, added deflate feature, refactored TLS features |
| madsim-tonic-build/Cargo.toml | Version bump to 0.6.0+0.13, updated tonic-build to 0.13 |
| madsim-etcd-client/Cargo.toml | Version bump to 0.7.0+0.16.0, updated etcd-client to 0.16 and tonic to 0.13 |
| madsim-tonic/src/transport/server.rs | Updated TLS cfg conditions, added add_optional_service, max_connection_age, http2_max_header_list_size, and trace_fn methods |
| madsim-tonic/src/transport/channel.rs | Updated TLS cfg conditions, added buffer_size, connect_lazy variants, tls_config, http2_max_header_list_size, executor, local_address, uri, and getter methods |
| madsim-tonic/src/sim.rs | Reorganized async_trait exports for better clarity and added to codegen module |
| CHANGELOG.md | Added release notes for tonic 0.6.0 and etcd-client 0.7.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Contributor
Author
|
May still directly bump to 0.14 #256 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that the latest version of tonic is actually
0.14. However, a large amount of crates in the ecosystem are still currently on0.13. It's still worthwhile to bump to 0.13 first before moving on.