Add support for debouncing non-GPIO inputs. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buttons can be connected via interfaces other than GPIO; for instance, using IO expanders over I2C or SPI, or via multiplexers. This patch adds the option to instantiate a debouncer without a pin specified; it also adds the option to pass an explicit value into `update()`. This means that you could make debouncers for buttons connected via, eg, an I2C expander; every update loop, read the values over I2C, and pass that value into the `update` method for the appropriate object.
Author
|
Downsides to this: my implementation requires using the 'full' constructor every time, because of parameter detection. I wonder if there is a better way of approaching that. Alternatively: don't use a different constructor, just pass in a GPIO that never gets read, and instead use the 'forced' update method. Open to suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buttons can be connected via interfaces other than GPIO; for instance, using IO expanders over I2C or SPI, or via multiplexers.
This patch adds the option to instantiate a debouncer without a pin specified; it also adds the option to pass an explicit value into
update().This means that you could make debouncers for buttons connected via, eg, an I2C expander; every update loop, read the values over I2C, and pass that value into the
updatemethod for the appropriate object.