Improve stability of sys crates #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're using the [`links`](https://doc.rust-lang.org/cargo/reference/build-scripts.html#the-links-manifest-key) key in `objc-sys` and `block-sys` to allow the user to customize linking, and use build script output in their own build scripts. However, these are _global_, meaning that you can't have two packages with the same key - this goes for packages with different versions. To avoid a situation where we can't use a new breaking version of these crates because everyone would have to update at the same time (no, the semver trick can't really save us here), we change the `links` key to include the version preemptively. Once we reach version 1.0 for these crates, we can go back to having a `links` key without a version number in it.
madsmtm
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #138, making a few changes that will help these sys crates be more stable in the long run.
I also included most of #117 so that the code doesn't go out of date.