Skip to content

Multiple fixes 2603#71

Merged
maehr merged 4 commits intomainfrom
multiple_fixes_2603
Mar 6, 2026
Merged

Multiple fixes 2603#71
maehr merged 4 commits intomainfrom
multiple_fixes_2603

Conversation

@maehr
Copy link
Owner

@maehr maehr commented Mar 6, 2026

Pull request

Proposed changes

Types of changes

  • New feature (non-breaking change which adds functionality).
  • Enhancement (non-breaking change which enhances functionality)
  • Bug Fix (non-breaking change which fixes an issue).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist

  • I have read the README document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Summary by CodeRabbit

  • New Features

    • Added Maintainers guide, example environment template, and citation metadata
    • Specified Node.js engine requirement
  • Documentation

    • Expanded contributing/setup instructions and updated project structure references
  • Chores

    • Added Python and R linting jobs and integrated them into CI
    • Narrowed changelog workflow trigger to main branch and updated action versions
    • Added pytest to dev deps, standardized formatting, and minor ignore/config updates

Copilot AI review requested due to automatic review settings March 6, 2026 09:28
@coderabbitai
Copy link

coderabbitai bot commented Mar 6, 2026

Warning

Rate limit exceeded

@maehr has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 3 minutes and 48 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c35bbbc7-4f93-4f53-be11-ae928efeb8d2

📥 Commits

Reviewing files that changed from the base of the PR and between 99997ad and 0eb7fab.

📒 Files selected for processing (1)
  • .github/workflows/quarto-publish.yml
📝 Walkthrough

Walkthrough

Updates across CI, configuration, tooling, and docs: adds lint-python and lint-r jobs and workflow concurrency, tightens changelog trigger, standardizes formatting and Node/Python tooling versions, and adds documentation and metadata updates (CITATION, CONTRIBUTING, MAINTAINERS, TODO, example.env).

Changes

Cohort / File(s) Summary
CI / Workflows
.github/workflows/quarto-publish.yml, .github/workflows/changelog.yaml, .github/workflows/greetings.yml
Added concurrency to publish workflow; introduced lint-python and lint-r jobs; updated deploy job dependencies to include new linters; narrowed changelog trigger to pushes on main; upgraded first-interaction action to v3.
Formatting & Devcontainer
.devcontainer/devcontainer.json, .prettierrc, site.webmanifest
Normalization of JSON/formatting and switching indentation from tabs to spaces (no semantic changes).
Ignore / Tooling files
.gitignore, .lycheerc.toml, .nvmrc, package.json, pyproject.toml
Broadened .lycheecache ignore pattern; added .nvmrc (Node 24) and engines.node: ">=24"; added pytest>=8.0.0 to dev deps.
Documentation & Templates
.github/MAINTAINERS.md, AGENTS.md, CONTRIBUTING.md, README.template.md, TODO.md, example.env, CITATION.cff
Added MAINTAINERS guidance for Quarto override, updated contributing env setup, removed build/ references, adjusted TODO checklist, replaced example.env content with templated guidance, and populated CITATION.cff metadata.

Sequence Diagram(s)

sequenceDiagram
  participant Push as "git push (main)"
  participant GH as "GitHub Actions"
  participant LintPy as "lint-python job"
  participant LintR as "lint-r job"
  participant LintJS as "lint (prettier) job"
  participant Build as "build-optimize job"
  participant Deploy as "deploy (pages) job"

  Push->>GH: trigger workflows
  GH->>LintPy: run lint-python
  GH->>LintR: run lint-r
  GH->>LintJS: run existing lint
  LintPy-->>GH: result (success/fail)
  LintR-->>GH: result (success/fail)
  LintJS-->>GH: result (success/fail)
  GH->>Build: run build-optimize (after lint jobs)
  Build-->>GH: build result
  GH->>Deploy: run deploy (needs: lint, lint-python, lint-r, build-optimize)
  Deploy-->>GH: publish pages / cancel-in-progress if concurrent
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • Better ci #21: Related edits to .github/workflows/quarto-publish.yml modifying CI job structure and dependencies.
  • Devcontainer #28: Overlaps on .devcontainer/devcontainer.json formatting/changes.
  • feat: fix #62 #64: Related Lychee/link-check changes touching .lycheerc.toml and ignore rules.

Suggested reviewers

  • mtwente

Poem

🐰 I hopped through JSON, tabs turned to space,
Linting now checks both R and Python's pace,
Docs got a polish, versions set to twenty-four,
CI prances cleaner than ever before—
A tiny rabbit cheer for repo lore!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is vague and generic, using non-specific language like 'Multiple fixes' that doesn't convey meaningful information about the changeset. Provide a more descriptive title that specifies the primary change, such as 'Add linting workflows and update Node.js version to 24' or 'Configure concurrency and enhance CI/CD pipeline'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The PR description follows the template structure and marks the change as a bug fix with documentation updates, but the 'Proposed changes' section lacks specific details about what bugs were fixed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch multiple_fixes_2603

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository template’s configuration, documentation, and CI workflows to improve maintainability and add additional linting/metadata defaults.

Changes:

  • Add Python (ruff/ty) and R (lintr) lint jobs to the Quarto publish workflow and gate deploy on them.
  • Introduce/clarify project metadata and maintenance docs (CITATION.cff, MAINTAINERS.md, env setup guidance).
  • Standardize formatting/config defaults (Prettier spaces, manifest/package JSON formatting, Node 24 via engines/.nvmrc).

Reviewed changes

Copilot reviewed 14 out of 20 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
site.webmanifest Reformat JSON indentation for consistency.
pyproject.toml Add pytest to dev dependency group.
package.json Reformat + add Node engine requirement (>=24).
example.env Add guidance comments for local .env setup.
TODO.md Update template checklist items (citation + project-management review).
README.template.md Remove outdated build/ directory reference.
CONTRIBUTING.md Document local environment setup using example.env.env.
CITATION.cff Populate a default Citation File Format record for the template.
AGENTS.md Remove outdated build/ references in guidance.
.prettierrc Switch Prettier to spaces (useTabs: false).
.nvmrc Pin Node major version to 24 for local dev.
.gitignore Adjust lychee cache ignore pattern.
.github/workflows/quarto-publish.yml Add concurrency + Python/R lint jobs; require them before deploy.
.github/workflows/greetings.yml Bump first-interaction action version.
.github/workflows/changelog.yaml Restrict changelog workflow trigger to main branch pushes.
.github/MAINTAINERS.md Add maintainer notes for _quarto.yml override behavior.
.devcontainer/devcontainer.json Reformat JSON indentation for consistency.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (1)
site.webmanifest (1)

2-3: Consider documenting placeholder convention for manifest fields.

The name and short_name fields are empty strings. If these are intentional placeholders for project instances to fill in, consider using a consistent placeholder format (like "SITE_NAME") to align with the placeholder policy documented in AGENTS.md for easier discovery during project setup.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@site.webmanifest` around lines 2 - 3, Replace the empty manifest fields
"name" and "short_name" with explicit, consistent placeholders (e.g.,
"SITE_NAME" and "SITE_SHORT_NAME") to signal they must be filled per instance
and update the project placeholder convention to match AGENTS.md; specifically
modify the "name" and "short_name" entries to use those placeholder tokens and
add a short note in the repo docs/AGENTS.md referencing that the web manifest
uses these tokens so setup scripts or contributors can discover and replace
them.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/quarto-publish.yml:
- Around line 17-19: The concurrency group is currently a top-level constant
("pages") which causes runs across branches to cancel each other; update the
concurrency.group value under the concurrency block to a ref-scoped string such
as '${{ github.workflow }}-${{ github.ref }}' (or alternatively remove the
top-level concurrency block and add a concurrency block scoped to the deploy
job) so builds are serialized per branch instead of globally; look for the
concurrency: block and the group: 'pages' line to make this change.

In `@example.env`:
- Around line 4-5: The sample environment variable name in the template doesn't
match the comment: update the placeholder ENV_VAR to API_KEY so the example and
comment align; replace the line containing ENV_VAR with a commented example like
API_KEY="your-api-key-here" (keeping it commented) and ensure the accompanying
comment above still reads "API key for an external service" to match the symbol
API_KEY.

---

Nitpick comments:
In `@site.webmanifest`:
- Around line 2-3: Replace the empty manifest fields "name" and "short_name"
with explicit, consistent placeholders (e.g., "SITE_NAME" and "SITE_SHORT_NAME")
to signal they must be filled per instance and update the project placeholder
convention to match AGENTS.md; specifically modify the "name" and "short_name"
entries to use those placeholder tokens and add a short note in the repo
docs/AGENTS.md referencing that the web manifest uses these tokens so setup
scripts or contributors can discover and replace them.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 43e4a9a8-14fa-435f-99c9-3bf7e43772f4

📥 Commits

Reviewing files that changed from the base of the PR and between ba14434 and 90f303f.

⛔ Files ignored due to path filters (2)
  • package-lock.json is excluded by !**/package-lock.json
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (18)
  • .devcontainer/devcontainer.json
  • .github/MAINTAINERS.md
  • .github/workflows/changelog.yaml
  • .github/workflows/greetings.yml
  • .github/workflows/quarto-publish.yml
  • .gitignore
  • .nvmrc
  • .prettierrc
  • AGENTS.md
  • CITATION.cff
  • CONTRIBUTING.md
  • README.template.md
  • TODO.md
  • example.env
  • package.json
  • pyproject.toml
  • site.webmanifest
  • test/conftest.py
💤 Files with no reviewable changes (1)
  • README.template.md

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/quarto-publish.yml:
- Around line 41-75: The lint jobs (lint-python and lint-r) currently inherit
excessive workflow permissions (pages: write and id-token: write); update each
job to explicitly set permissions to the minimal required scope by adding a
permissions override with contents: read for both the lint-python job and the
lint-r job (e.g., add a permissions: block containing contents: read under the
lint-python and lint-r job definitions) so they do not retain write/deployment
scopes.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ad72e29b-6ffe-4a09-b8d8-e403afaffb32

📥 Commits

Reviewing files that changed from the base of the PR and between 90f303f and 99997ad.

📒 Files selected for processing (3)
  • .github/workflows/quarto-publish.yml
  • .lycheerc.toml
  • example.env
🚧 Files skipped from review as they are similar to previous changes (1)
  • example.env

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants