Conversation
Test Results151 tests 150 ✅ 6s ⏱️ Results for commit 9a1c01a. ♻️ This comment has been updated with latest results. |
GIVEN53
approved these changes
Mar 31, 2025
Member
GIVEN53
left a comment
GIVEN53
left a comment
There was a problem hiding this comment.
고생 많으셨습니다 👍🏻 구현 깔끔해서 사소한 코멘트정도만 남겼습니다
시간되실 때 천천히 확인해주세요 :)
| import maeilwiki.mutiplechoice.domain.Option; | ||
| import maeilwiki.mutiplechoice.domain.WorkbookQuestion; | ||
|
|
||
| public record OptionRequest(String content, boolean isCorrectAnswer) { |
Member
There was a problem hiding this comment.
order 빼주셨네요 👍🏻 API 명세도 수정이 필요할 것 같습니다
Member
Author
There was a problem hiding this comment.
API 명세 변경했습니다! 추후에 데이터베이스에 order를 저장할 수도 있으니(옵션 순서 변경) ERD는 따로 수정하지 않을게요.
ddl.sql
Outdated
| solved_count int not null, | ||
| member_id bigint not null, | ||
| created_at datetime(6) not null, | ||
| updated_at datetime(6) not null, |
Member
There was a problem hiding this comment.
새로운 테이블들의 시간관련 컬럼은 datetime인 이유가 있을까요?? (단순 궁금증)
Member
Author
There was a problem hiding this comment.
놓치고 있던 부분이네요. timestamp로 변경했습니다!
| @NoArgsConstructor(access = AccessLevel.PROTECTED) | ||
| public class TimeLimit { | ||
|
|
||
| private static final List<Integer> TIME_TABLE = List.of(5, 10, 15, 20, 25, 30, 40, 50, 60); |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[연관 관계]
객관식 문제 출제 기능을 구현했어요. workbook -n-> question -n-> option 관계를 데이터베이스 구조에 맞춰서 ManyToOne으로 관계를 설정했습니다. 양방향을 고려하거나, 도메인 객체를 JPA로부터 분리하는 선택지가 있었지만, 얻는 이점에 비해서 현재처럼 단순하게 가져가는 것이 낫다고 생각했어요.
[저장]
workbookRepository에서 questions를 받아서 저장하는데, questionRepository로 분리할지 고민됩니다. 또한, 저장과 관련해서 persist를 고려했으나, 카톡에서 논의한 것처럼 성능상 문제로 batch insert를 사용하도록 구현했습니다.