Remove the check for the unused scope "RoleEligibilitySchedule.ReadWrite.Directory" #1389
+2
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove check for RoleEligibilitySchedule.ReadWrite.Directory scope For more context on the reason see maester365#195 (comment)
RoleEligibilitySchedule.ReadWrite.Directory is no longer used and is not included in [Get-MtGraphScope](https://github.com/maester365/maester/blob/main/powershell/public/Get-MtGraphScope.ps1). The existing scope check was therefore invalid and caused the test to always be skipped. This PR removes the outdated check so the test can run correctly.
RoleEligibilitySchedule.ReadWrite.Directory is no longer used and is not included in [Get-MtGraphScope](https://github.com/maester365/maester/blob/main/powershell/public/Get-MtGraphScope.ps1). The existing scope check was therefore invalid and caused the test to always be skipped. This PR removes the outdated check so the test can run correctly.
mrdos010
changed the title
mrdos010
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes an outdated and invalid scope check for RoleEligibilitySchedule.ReadWrite.Directory that was causing tests to be incorrectly skipped. The scope is not included in Get-MtGraphScope and is not required for the underlying Graph API calls, which use the RoleManagement.Read.All scope instead.
- Removes invalid permission checks from three test functions
- Enables tests to run correctly with the standard scopes from
Get-MtGraphScope - Improves code consistency across test files
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| powershell/public/cisa/entra/Test-MtCisaGlobalAdminRatio.ps1 | Removed invalid scope check that was preventing the test from running |
| powershell/public/cisa/entra/Test-MtCisaCloudGlobalAdmin.ps1 | Removed invalid scope check that was preventing the test from running |
| powershell/public/cis/Test-MtCisGlobalAdminCount.ps1 | Removed invalid scope check that was preventing the test from running |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SamErde
approved these changes
Jan 5, 2026
Contributor
|
Thanks, @mrdos010! Looks good. Testing with my lunch today! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RoleEligibilitySchedule.ReadWrite.Directory is no longer used and is not included in Get-MtGraphScope.
The existing scope check was therefore invalid and caused the test to always be skipped.
This PR removes the outdated check so the test can run correctly.