Fix diagnostic settings retrieval to ensure array output #1392
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forces $diagnosticSettings to be returned as an array, even if only one diagnostic setting object exists. Required for the `foreach ($entry in $diagnosticSettings)` statement to properly handle the results as an array.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the diagnostic settings retrieval could fail when only a single diagnostic setting object is returned from the API. By wrapping the result in the PowerShell array subexpression operator @(), the variable is guaranteed to be an array, preventing issues with the foreach loop that iterates over the results.
- Forces
$diagnosticSettingsto always be an array type, even when a single object is returned - Ensures the
foreachloop on line 40 properly handles all scenarios (zero, one, or multiple diagnostic settings)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Deploying maester with
|
| Latest commit: |
89927d2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://093f97d5.maester.pages.dev |
| Branch Preview URL: | https://samerde-patch-1.maester.pages.dev |
Cloud-Architekt
approved these changes
Jan 17, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Forces $diagnosticSettings to be returned as an array, even if only one diagnostic setting object exists. Required for the
foreach ($entry in $diagnosticSettings)statement to properly handle the results as an array.Fixes #1391
Contribution Checklist
Before submitting this PR, please confirm you have completed the following:
/powershell/tests/pester.ps1on your local system.Join us at the Maester repository discussions 💬 or Entra Discord 🧑💻 for more help and conversations!