feat(components): visualize api errors for steppers#1931
Open
huzaifaedhi22 wants to merge 13 commits intomainfrom
Open
feat(components): visualize api errors for steppers#1931huzaifaedhi22 wants to merge 13 commits intomainfrom
huzaifaedhi22 wants to merge 13 commits intomainfrom
Conversation
dargmuesli
reviewed
May 15, 2025
| if (result.error || !result.data) return | ||
|
|
||
| if (result.error || !result.data) { | ||
| modelError.value = new Error() |
Member
There was a problem hiding this comment.
Why an empty error here instead of adding a watch on api.value.errors as in the other places?
Contributor
Author
There was a problem hiding this comment.
This function is going to fail silently (security reasons) and their would be no error response from backend so I suppose we only need to take care of broken network connection.
dargmuesli
changed the title
dargmuesli
requested changes
May 19, 2025
| createdBy: accountId, | ||
| }, | ||
| }) | ||
|
|
Member
There was a problem hiding this comment.
no need to remove empty lines before if statements, we have them all across the code
| text: t('globalErrorNoData'), | ||
| title: t('globalError'), | ||
| }) | ||
| error.value = new Error(t('globalError')) |
Member
There was a problem hiding this comment.
Why not globalErrorNoData anymore?
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Description
This PR visualizes api errors for
📝 Checklist