feat(pages): add idea, issue and report forms#1980
feat(pages): add idea, issue and report forms#1980huzaifaedhi22 wants to merge 15 commits intobetafrom
Conversation
huzaifaedhi22
changed the title
dargmuesli
changed the title
There was a problem hiding this comment.
I see an icon called "exclamation" in the components & styles design, but this icon looks to be different. At least it has a different name here. This could be aligned.
There was a problem hiding this comment.
Aligned, you can resolve or comment if necessary.
| }) | ||
| " | ||
| > | ||
| <AppIconReport /> |
There was a problem hiding this comment.
Is AppIconReport added in this PR? I don't see it. According to my comment above an AppIconExclamation could be added.
There was a problem hiding this comment.
Resolved, you can mark as resolved when checked.
src/app/pages/session/edit/index.vue
Outdated
| @@ -90,14 +90,22 @@ | |||
| <CardButton | |||
| is-external | |||
There was a problem hiding this comment.
The is-externals are not correct anymore and needs to be removed for single page routing to work. You can see the page doing a full reload on click when it could instead just load the missing content.
There was a problem hiding this comment.
The new support pages should be placed into the support directory too, same as for the existing contact page, or the pages directory's contents will get fairly lengthy. I'll move them, you can resolve when understood.
dargmuesli
force-pushed
the
feat/monday-forms
branch
from
3ee1890 to
2187d13
Compare
|
|
| if (files.length > 0) { | ||
| for (const file of files) { |
There was a problem hiding this comment.
why the if? If files was empty, the loop wouldn't run, I'd say.
There was a problem hiding this comment.
The support form definitions are very repetitive, parts should be outsourced to components.
There was a problem hiding this comment.
The support form page definitions are very repetitive, parts should be outsourced to components.
dargmuesli
force-pushed
the
feat/monday-forms
branch
3 times, most recently
from
04a01a7 to
731aba4
Compare
dargmuesli
force-pushed
the
feat/monday-forms
branch
from
731aba4 to
d9bd2de
Compare
dargmuesli
force-pushed
the
beta
branch
3 times, most recently
from
28c9fa5 to
8c69f32
Compare
3 participants
📚 Description
This PR adds Monday forms for
📝 Checklist