See output of external commands like --omx or --on-listening#222
Open
manuhabitela wants to merge 2 commits intomafintosh:masterfrom
Open
See output of external commands like --omx or --on-listening#222manuhabitela wants to merge 2 commits intomafintosh:masterfrom
--omx or --on-listening#222manuhabitela wants to merge 2 commits intomafintosh:masterfrom
Conversation
this allows to have omx keyboard shortcuts working
this allows to see the output of given scripts directly
manuhabitela
force-pushed
the
spawn-scripts
branch
from
7c0269d to
fe827b8
Compare
Owner
|
Doesn't this mess up the output when we're already drawing the peers you are connected to? |
Author
|
Gah, didn't see you answered :) I guess it could mess up the output sometimes... Didn't bother me with Maybe those options could check the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, thanks for peerflix which works incredibly well :)
I started to use it on a tiny project and stumbled upon something when using
--omxor--on-listening: those external commands' outputs were not visible.I figured it could be useful to have the output of those commands directly in the cli, so I changed the
execcall for theomx,on-listeningandon-downloadedoptions and replaced it withspawn(edit: I just changed those because they are the only ones I tested).I did this mostly because when I want to use peerflix from a raspberry pi and omx, the omx keyboard shortcuts don't work with a simple
exec.What do you think?