Open
Conversation
if a subtitle by the name of video.srt is present in the same folder as the video file => use it.
Owner
|
could you remove the 2nd pair of DLNA headers we set further down then? That way we don't set them twice. Other than that LGTM |
|
Well, the second pair of DLNA headers are the entire commit as he removed the subtitle stuff. But he removed the subtitle stuff because he realized that he's setting a subtitle from a server that he wasn't creating. Even if he would though.. Or tweak it to use peerflix's http server for this, setting subtitles with the |
Mikescops
reviewed
Jan 25, 2023
| response.setHeader('Content-Length', range.end - range.start + 1) | ||
| response.setHeader('Content-Range', 'bytes ' + range.start + '-' + range.end + '/' + file.length) | ||
| response.setHeader('transferMode.dlna.org', 'Streaming') | ||
| response.setHeader('contentFeatures.dlna.org', 'DLNA.ORG_OP=01;DLNA.ORG_CI=0;DLNA.ORG_FLAGS=017000 00000000000000000000000000') |
There was a problem hiding this comment.
oups sorry reviving an old thread mb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add relevant DLNA headers to the server.