Allow overwrite “accessModes” to support AWS ebs for k8s volumes#74
Open
devopsmash wants to merge 1 commit intomage-ai:masterfrom
Open
Allow overwrite “accessModes” to support AWS ebs for k8s volumes#74devopsmash wants to merge 1 commit intomage-ai:masterfrom
devopsmash wants to merge 1 commit intomage-ai:masterfrom
Conversation
Author
|
Hi @wangxiaoyou1993 , please let me now if additional info is needed or if something is unclear. |
Member
|
Will review the PR today |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
I've added additional custom values file (custom-values.yaml) with the following content:
Test commands
Notes:
.Values.volumesfrom the helm chartcloses #70
Inspired from the Jenkins helm chart