Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for Kubernetes PodDisruptionBudget (PDB) in the Helm chart configuration for both the webServer and scheduler components.
- Adds new configuration entries in values.yaml for PDB options.
- Introduces two new template files (pdb.yaml and pdb-scheduler.yaml) to generate PDB resources based on the new configuration.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| charts/mageai/values.yaml | Adds PDB configuration options for webServer and scheduler |
| charts/mageai/templates/pdb.yaml | New template to create a PDB for the webServer component based on values.yaml |
| charts/mageai/templates/pdb-scheduler.yaml | New template to create a PDB for the scheduler component based on values.yaml |
Comments suppressed due to low confidence (1)
charts/mageai/templates/pdb.yaml:10
- [nitpick] Consider using nindent for the minAvailable and maxUnavailable keys to ensure consistent and proper YAML indentation in the generated manifest.
{{- if .Values.webServer.PodDisruptionBudget.minAvailable }}
younsl
reviewed
Aug 5, 2025
younsl
reviewed
Aug 5, 2025
Member
|
Did you test your change? |
Signed-off-by: fe80 <steffyfort@gmail.com>
Author
|
I had missed the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This feature add the support of PodDisruptionBudget
Tests
cc: