[dev] Change gen-card.pl to bail after checking set print info#14691
Open
muz wants to merge 1 commit intomagefree:masterfrom
Open
[dev] Change gen-card.pl to bail after checking set print info#14691muz wants to merge 1 commit intomagefree:masterfrom
muz wants to merge 1 commit intomagefree:masterfrom
Conversation
…of the card already being implemented
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously if the card was already implemented, it would die on line 127.
Now, we set a flag that is checked after the set printing info stuff is done.
This enables cards that are implemented to just have
gen-card.plran against them and the set info auto update from the script. Useful for when WotC produces later reprints of existing cards OR when things are under rapid development during spoiler and preview season and not all card printings are known during initial implementation.