Merge pull request #44 from magento-cia/MC-41838

MC-41838: Simplify paths

Author: dvoskoboinikov

AdobeStockImage/Model/Storage/Save.php

@@ -39,19 +39,27 @@ class Save
      */
     private $isPathExcluded;
 
+    /**
+     * @var int|null
+     */
+    private $maxFileLength;
+
     /**
      * @param Filesystem $filesystem
      * @param Https $driver
      * @param IsPathExcludedInterface $isPathExcluded
+     * @param int|null $maxFileLength
      */
     public function __construct(
         Filesystem $filesystem,
         Https $driver,
-        IsPathExcludedInterface $isPathExcluded
+        IsPathExcludedInterface $isPathExcluded,
+        int $maxFileLength = null
     ) {
         $this->filesystem = $filesystem;
         $this->driver = $driver;
         $this->isPathExcluded = $isPathExcluded;
+        $this->maxFileLength = $maxFileLength ?: 255;
     }
 
     /**
@@ -66,6 +74,10 @@ public function __construct(
      */
     public function execute(string $imageUrl, string $destinationPath, bool $allowOverwrite = false): void
     {
+        if (strlen($destinationPath) > $this->maxFileLength) {
+            throw new LocalizedException(__('Destination Path is too long; must be %1 characters or less', $this->maxFileLength));
+        }
+
         $mediaDirectory = $this->filesystem->getDirectoryWrite(DirectoryList::MEDIA);
 
         if ($this->isPathExcluded->execute($destinationPath)) {

AdobeStockImage/etc/di.xml

@@ -36,6 +36,7 @@
     <type name="Magento\AdobeStockImage\Model\Storage\Save">
         <arguments>
             <argument name="driver" xsi:type="object">Magento\Framework\Filesystem\Driver\Https</argument>
+            <argument name="maxFileLength" xsi:type="number">255</argument>
         </arguments>
     </type>
     <type name="Magento\AdobeStockImage\Model\GetRelatedImages">