Review changes

Author: konarshankar07

…zation/Model/GenerateRenditionImages.php …itions/Model/GenerateRenditionImages.phpMediaGallerySynchronization/Model/GenerateRenditionImages.php renamed to MediaGalleryRenditions/Model/GenerateRenditionImages.php MediaGallerySynchronization/Model/GenerateRenditionImages.php renamed to MediaGalleryRenditions/Model/GenerateRenditionImages.php

@@ -5,10 +5,11 @@
  */
 declare(strict_types=1);
 
-namespace Magento\MediaGallerySynchronization\Model;
+namespace Magento\MediaGalleryRenditions\Model;
 
 use Magento\MediaGallerySynchronizationApi\Api\ImportFileInterface;
 use Magento\MediaGallerySynchronization\Model\Filesystem\SplFileInfoFactory;
+use Magento\MediaGallerySynchronization\Model\CreateAssetFromFile;
 use Magento\MediaGalleryRenditionsApi\Api\GenerateRenditionsInterface;
 
 /**
@@ -52,7 +53,6 @@ public function __construct(
     public function execute(string $path): void
     {
         $file = $this->splFileInfoFactory->create($path);
-        $createdAsset = $this->createAssetFromFile->execute($file);
-        $this->generateRenditions->execute([$createdAsset]);
+        $this->generateRenditions->execute([$this->createAssetFromFile->execute($file)]);
     }
 }

MediaGalleryRenditions/composer.json

@@ -3,7 +3,9 @@
     "description": "Magento module that implements height and width fields for for media gallery items.",
     "require": {
         "php": "~7.3.0||~7.4.0",
-        "magento/framework": "*"
+        "magento/framework": "*",
+        "magento/module-media-gallery-synchronization-api": "*",
+        "magento/module-media-gallery-synchronization": "*"
     },
     "type": "magento2-module",
     "license": [

MediaGalleryRenditions/etc/di.xml

@@ -9,4 +9,11 @@
     <preference for="Magento\MediaGalleryRenditionsApi\Model\ConfigInterface" type="Magento\MediaGalleryRenditions\Model\Config"/>
     <preference for="Magento\MediaGalleryRenditionsApi\Api\GenerateRenditionsInterface" type="Magento\MediaGalleryRenditions\Model\GenerateRenditions"/>
     <preference for="Magento\MediaGalleryRenditionsApi\Api\GetRenditionPathInterface" type="Magento\MediaGalleryRenditions\Model\GetRenditionPath"/>
+    <type name="Magento\MediaGallerySynchronizationApi\Model\ImportFileComposite">
+        <arguments>
+            <argument name="importers" xsi:type="array">
+                <item name="2" xsi:type="object">Magento\MediaGalleryRenditions\Model\GenerateRenditionImages</item>
+            </argument>
+        </arguments>
+    </type>
 </config>

MediaGalleryRenditions/etc/module.xml

@@ -6,5 +6,9 @@
  */
 -->
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
-    <module name="Magento_MediaGalleryRenditions" />
+    <module name="Magento_MediaGalleryRenditions">
+        <sequence>
+            <module name="Magento_MediaGallerySynchronizationApi" />
+        </sequence>
+    </module>
 </config>

MediaGallerySynchronization/composer.json

@@ -5,7 +5,6 @@
         "php": "~7.3.0||~7.4.0",
         "magento/framework": "*",
         "magento/module-media-gallery-api": "*",
-        "magento/module-media-gallery-renditions-api": "*",
         "magento/module-media-gallery-synchronization-api": "*",
         "magento/framework-message-queue": "*",
         "magento/module-media-gallery-metadata-api": "*"

MediaGallerySynchronization/etc/di.xml

@@ -15,7 +15,6 @@
             <argument name="importers" xsi:type="array">
                 <item name="0" xsi:type="object">Magento\MediaGallerySynchronization\Model\ImportMediaAsset</item>
                 <item name="1" xsi:type="object">Magento\MediaGallerySynchronization\Model\ImportImageFileKeywords</item>
-                <item name="generateRenditionImages" xsi:type="object">Magento\MediaGallerySynchronization\Model\GenerateRenditionImages</item>
             </argument>
         </arguments>
     </type>