Skip to content

Check correct variable for null #3398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
+1 −1
Open

Check correct variable for null #3398

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d892fff
Check correct variable for null
dennisvanderweide Sep 18, 2023
509bda8
Merge branch 'develop' into patch-1
engcom-Hotel Sep 24, 2025
870ccb7
Merge branch 'magento:develop' into patch-1
dennisvanderweide Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion InventoryCatalog/Model/ResourceModel/BulkInventoryTransfer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ private function transferInventory(

if ($orgSourceItem !== null) {
$status = (int) $orgSourceItem[SourceItemInterface::STATUS];
} elseif ($dstSourceItemQty !== null) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @dennisvanderweide,

Thank you for your contribution!

Please let us know in which scenario the existing will create an issue.

Also please help us with the manual testing scenario.

Thank you

Copy link
Author

@dennisvanderweide dennisvanderweide Sep 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@engcom-Hotel In case $dstSourceItem is null, $dstSourceItemQty will be 0.0 (line 124). If $orgSourceItem is also null it will trigger this if statement. $dstSourceItemQty !== null will be false, because it will be 0.0, but dstSourceItem is still null. $dstSourceItem[SourceItemInterface::STATUS] then gives an error.

I don't know how $orgSourceItem and $dstSourceItem can be both null, both this happend with one of our customers and I saw that this if statement doesn't handle this correctly.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense to me thank you for the clarification.

} elseif ($dstSourceItem !== null) {
$status = (int) $dstSourceItem[SourceItemInterface::STATUS];
} else {
$status = (int) SourceItemInterface::STATUS_OUT_OF_STOCK;
Expand Down