Skip to content

Commit 2dd95a3

Browse files
committed
fixed review comments
1 parent 27d4667 commit 2dd95a3

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/Analyzer/EtSchemaAnalyzer.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ private function changedField(string $moduleName, string $recordName, string $fi
222222
* @param $afterRecord
223223
* @return array
224224
*/
225-
private function analyzeRecord(string $moduleName, $beforeRecord, $afterRecord): array
225+
private function analyzeRecord(string $moduleName, array $beforeRecord, array $afterRecord): array
226226
{
227227
$changes = [];
228228
$commonFields = array_intersect(
@@ -231,8 +231,8 @@ private function analyzeRecord(string $moduleName, $beforeRecord, $afterRecord):
231231
);
232232
foreach ($commonFields as $fieldName) {
233233
if (
234-
$beforeRecord['field'][$fieldName]['type'] != $afterRecord['field'][$fieldName]['type']
235-
|| $beforeRecord['field'][$fieldName]['repeated'] != $afterRecord['field'][$fieldName]['repeated']
234+
$beforeRecord['field'][$fieldName]['type'] !== $afterRecord['field'][$fieldName]['type']
235+
|| $beforeRecord['field'][$fieldName]['repeated'] !== $afterRecord['field'][$fieldName]['repeated']
236236
) {
237237
$changes[] = $this->changedField($moduleName, $beforeRecord['name'], $fieldName);
238238
}

0 commit comments

Comments
 (0)