Skip to content

Commit 46c6f75

Browse files
committed
MAGETWO-92821: [Tech Debt] Update slide & slider forms to use true / false values instead of 0 / 1
- Fix broken test, show dots is enabled earlier in the test but not validated to be yes
1 parent c6f5afc commit 46c6f75

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Data/SliderData.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,12 @@
5656
<data key="fieldName">show_dots</data>
5757
<data key="value">false</data>
5858
</entity>
59+
<entity name="PageBuilderSliderShowDotsYesProperty" type="pagebuilder_slider_property">
60+
<data key="name">Show dots</data>
61+
<data key="section">settings</data>
62+
<data key="fieldName">show_dots</data>
63+
<data key="value">true</data>
64+
</entity>
5965
<!-- Minimum Height -->
6066
<entity name="PageBuilderSliderMinHeightDefault300Property" type="pagebuilder_slider_property">
6167
<data key="name">Minimum Height</data>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderSlideCommonTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@
194194
<seeElement selector="{{SliderOnFrontend.Fade(PageBuilderSliderFadeYesProperty.value)}}" stepKey="seeSliderFadeSetting"/>
195195
<seeElement selector="{{SliderOnFrontend.IsInfinite(PageBuilderSliderIsInfiniteProperty.value)}}" stepKey="seeSliderIsInfiniteSetting"/>
196196
<seeElement selector="{{SliderOnFrontend.ShowArrows(PageBuilderSliderShowArrowsYesProperty.value)}}" stepKey="seeSliderShowArrowsSetting"/>
197-
<seeElement selector="{{SliderOnFrontend.ShowDots(PageBuilderSliderShowDotsNoProperty.value)}}" stepKey="seeSliderShowDotsOffOnFrontendSetting"/>
197+
<seeElement selector="{{SliderOnFrontend.ShowDots(PageBuilderSliderShowDotsYesProperty.value)}}" stepKey="seeSliderShowDotsOffOnFrontendSetting"/>
198198
<seeElement selector="{{SliderOnFrontend.sliderBorder(PageBuilderAdvancedBorderWidthProperty10.value, PageBuilderAdvancedBorderPropertyDotted.value, PageBuilderAdvancedBorderColorProperty_green.rbg)}}" stepKey="verifyBorderStyleOnStorefront"/>
199199
<seeElement selector="{{SliderOnFrontend.sliderMinHeight(PageBuilderSliderMinHeight500Property.value)}}" stepKey="verifyMinHeightOnFrontEnd"/>
200200
<seeElement selector="{{SliderOnFrontend.sliderMarginPaddings(PageBuilderAdvancedMarginsAndPaddingProperty.marginTop, PageBuilderAdvancedMarginsAndPaddingProperty.paddingTop)}}" stepKey="verifySliderMarginPaddingOnFrontEnd"/>

0 commit comments

Comments
 (0)