MAGETWO-92335: Architecture Review

- Resolved data scoping issue and map utility reversion to location_name

Author: Michael Yu

app/code/Magento/PageBuilder/view/adminhtml/ui_component/pagebuilder_map_form.xml

@@ -150,7 +150,6 @@
                     <class name="admin__field-wide">true</class>
                 </additionalClasses>
                 <componentType>dynamicRows</componentType>
-                <dataScope>location</dataScope>
             </settings>
             <container name="record" component="Magento_Ui/js/dynamic-rows/record">
                 <argument name="data" xsi:type="array">

app/code/Magento/PageBuilder/view/adminhtml/web/js/form/components/dynamic-rows.js

@@ -101,7 +101,7 @@ define([
                 allLabels,
                 placeholder;
 
-            if (property().name === "actions") {
+            if (property().name === 'actions') {
                 return;
             }
 

app/code/Magento/PageBuilder/view/adminhtml/web/template/content-type/map/default/master.html

@@ -5,4 +5,4 @@
  */
 -->
 
-<div attr="data.main.attributes" data-bind="afterRender: function(){console.log(data.main.attributes())}" ko-style="Object.assign({}, { display: data.main.attributes()['data-locations'] !== '[]' ? 'inline-block' : 'none' }, data.main.style())" css="data.main.css"></div>
+<div attr="data.main.attributes" ko-style="Object.assign({}, { display: data.main.attributes()['data-locations'] !== '[]' ? 'inline-block' : 'none' }, data.main.style())" css="data.main.css"></div>

app/code/Magento/PageBuilder/view/base/web/js/utils/map.js

@@ -72,7 +72,7 @@ define([
              */
             if (newMarkers && newMarkers.length) {
                 newMarkers.forEach(function (newMarker) {
-                    var name = newMarker.name || '',
+                    var location = newMarker['location_name'] || '',
                     comment = newMarker.comment ?
                         '<p>' + newMarker.comment.replace(/(?:\r\n|\r|\n)/g, '<br/>') + '</p>'
                         : '',
@@ -86,7 +86,7 @@ define([
                     lineBreak = city !== '' || zipCode !== '' ? '<br/>' : '',
                     contentString =
                         '<div>' +
-                        '<h3><b>' + name + '</b></h3>' +
+                        '<h3><b>' + location + '</b></h3>' +
                         comment +
                         phone +
                         '<p><span>' + address +
@@ -100,10 +100,10 @@ define([
                     newCreatedMarker = new google.maps.Marker({
                         map: this.map,
                         position: getGoogleLatitudeLongitude(newMarker.position),
-                        title: name
+                        title: location
                     });
 
-                    if (name) {
+                    if (location) {
                         newCreatedMarker.addListener('click', function () {
                             if (activeInfoWindow) {
                                 activeInfoWindow.close();