Skip to content

Commit 51c6c3f

Browse files
committed
MC-4128: Minimum Height doesn't work with Parallax turned ON for Row Content Type on stage preview
Address CR feedback
1 parent 2ccb26e commit 51c6c3f

File tree

2 files changed

+13
-23
lines changed

2 files changed

+13
-23
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Data/RowData.xml

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -122,16 +122,4 @@
122122
<data key="fieldName">parallax_speed</data>
123123
<data key="value">2.0</data>
124124
</entity>
125-
<entity name="PageBuilderRowMinimumHeightProperty" type="pagebuilder_row_minimumHeight_property">
126-
<data key="name">Minimum Height</data>
127-
<data key="section">layout</data>
128-
<data key="fieldName">min_height</data>
129-
<data key="value">450</data>
130-
</entity>
131-
<entity name="PageBuilderRowMinimumHeightProperty_2" type="pagebuilder_row_minimumHeight_property">
132-
<data key="name">Minimum Height</data>
133-
<data key="section">layout</data>
134-
<data key="fieldName">min_height</data>
135-
<data key="value">400</data>
136-
</entity>
137125
</entities>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderRowTest.xml

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1837,7 +1837,7 @@
18371837
<features value="PageBuilder"/>
18381838
<stories value="Row"/>
18391839
<title value="Row - Minimum Height Obeyed when Parallax is enabled"/>
1840-
<description value="As a Content Manager I want minimum height of parallax-enabled row to reflect the same value configured by user"/>
1840+
<description value="As a Content Manager I want minimum height of parallax-enabled row to reflect the same value configured by me"/>
18411841
<severity value="CRITICAL"/>
18421842
<useCaseId value="MC-4128"/>
18431843
<testCaseId value="MC-4304"/>
@@ -1859,29 +1859,31 @@
18591859
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage">
18601860
<argument name="contentType" value="PageBuilderRowContentType"/>
18611861
</actionGroup>
1862-
<actionGroup ref="clickSlideOutPanelFieldGeneral" stepKey="enterParallaxEnabledProperty">
1863-
<argument name="property" value="PageBuilderRowParallax_Default"/>
1862+
<actionGroup ref="conditionalClickSlideOutPanelFieldGeneral" stepKey="enterParallaxEnabledProperty">
1863+
<argument name="property" value="PageBuilderRowParallax_Enabled"/>
18641864
</actionGroup>
18651865
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinimumHeightProperty">
1866-
<argument name="property" value="PageBuilderRowMinimumHeightProperty"/>
1866+
<argument name="property" value="PageBuilderMinHeightProperty_300"/>
18671867
</actionGroup>
18681868
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings3"/>
1869-
<executeJS function="return parseInt(document.evaluate(&quot;{{RowOnStage.base('1')}}&quot;, document.body).iterateNext().style.minHeight, 10)" stepKey="computedHeight" />
1869+
<!-- Get value of assigned min height on element -->
1870+
<executeJS function="return parseInt(document.evaluate(&quot;{{RowOnStage.base('1')}}&quot;, document.body).iterateNext().style.minHeight, 10)" stepKey="assignedHeight" />
18701871
<assertEquals stepKey="assertEqualToEnteredValue">
1871-
<expectedResult type="string">{{PageBuilderRowMinimumHeightProperty.value}}</expectedResult>
1872-
<actualResult type="variable">$computedHeight</actualResult>
1872+
<expectedResult type="string">{{PageBuilderMinHeightProperty_300.value}}</expectedResult>
1873+
<actualResult type="variable">$assignedHeight</actualResult>
18731874
</assertEquals>
18741875
<actionGroup ref="openPageBuilderEditPanel" stepKey="openEditMenuOnStage2">
18751876
<argument name="contentType" value="PageBuilderRowContentType"/>
18761877
</actionGroup>
18771878
<actionGroup ref="fillSlideOutPanelFieldGeneral" stepKey="enterMinimumHeightProperty2">
1878-
<argument name="property" value="PageBuilderRowMinimumHeightProperty_2"/>
1879+
<argument name="property" value="PageBuilderMinHeightProperty_500"/>
18791880
</actionGroup>
18801881
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings4"/>
1881-
<executeJS function="return parseInt(document.evaluate(&quot;{{RowOnStage.base('1')}}&quot;, document.body).iterateNext().style.minHeight, 10)" stepKey="computedHeight2" />
1882+
<!-- Get value of assigned min height on element -->
1883+
<executeJS function="return parseInt(document.evaluate(&quot;{{RowOnStage.base('1')}}&quot;, document.body).iterateNext().style.minHeight, 10)" stepKey="assignedHeight2" />
18821884
<assertEquals stepKey="assertEqualToEnteredValue2">
1883-
<expectedResult type="string">{{PageBuilderRowMinimumHeightProperty_2.value}}</expectedResult>
1884-
<actualResult type="variable">$computedHeight2</actualResult>
1885+
<expectedResult type="string">{{PageBuilderMinHeightProperty_500.value}}</expectedResult>
1886+
<actualResult type="variable">$assignedHeight2</actualResult>
18851887
</assertEquals>
18861888
</test>
18871889
</tests>

0 commit comments

Comments
 (0)