Skip to content

Commit 6874517

Browse files
anthoulaanthoula
committed
MC-3723: Advanced properties saving when invalid value is specified
- update padding test - remove invalid cases to new test - remove redundant cases
1 parent 8eae47a commit 6874517

File tree

1 file changed

+19
-152
lines changed

1 file changed

+19
-152
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderAdvancedConfigurationTest.xml

Lines changed: 19 additions & 152 deletions
Original file line numberDiff line numberDiff line change
@@ -2382,11 +2382,10 @@
23822382
<stories value="Advanced Configuration"/>
23832383
<title value="Functional - Padding"/>
23842384
<description value="Tests that the Padding attributes functions as expected on Stage and Storefront for Text"/>
2385-
<severity value="CRITICAL"/>
2385+
<severity value="MAJOR"/>
23862386
<useCaseId value="MAGETWO-83415"/>
23872387
<testCaseId value="MC-2611"/>
23882388
<group value="pagebuilder"/>
2389-
<group value="pagebuilder-me"/>
23902389
<group value="pagebuilder-advancedConfig"/>
23912390
</annotations>
23922391
<before>
@@ -2400,32 +2399,24 @@
24002399
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
24012400
<argument name="contentType" value="PageBuilderTextContentType"/>
24022401
</actionGroup>
2403-
<!-- Add A Row For Each Text Padding Test -->
2404-
<comment userInput="Add Rows" stepKey="commentAddRows"/>
2405-
<actionGroup ref="dragContentTypeToStage" stepKey="dragRowIntoStage1">
2406-
<argument name="contentType" value="PageBuilderRowContentType"/>
2407-
</actionGroup>
2408-
<actionGroup ref="dragContentTypeToStage" stepKey="dragRowIntoStage2">
2409-
<argument name="contentType" value="PageBuilderRowContentType"/>
2410-
</actionGroup>
2411-
<actionGroup ref="dragContentTypeToStage" stepKey="dragRowIntoStage3">
2412-
<argument name="contentType" value="PageBuilderRowContentType"/>
2413-
</actionGroup>
2414-
<actionGroup ref="dragContentTypeToStage" stepKey="dragRowIntoStage4">
2415-
<argument name="contentType" value="PageBuilderRowContentType"/>
2416-
</actionGroup>
2417-
<!-- Add Padding: Empty -->
2418-
<comment userInput="Add Padding: Empty" stepKey="commentAddPaddingEmpty"/>
24192402
<actionGroup ref="expandPageBuilderPanelGroup" stepKey="expandPageBuilderPanelGroup">
24202403
<argument name="group" value="PageBuilderTextContentType"/>
24212404
</actionGroup>
2422-
<actionGroup ref="dragContentTypeToContainer" stepKey="dragTextIntoStage1">
2405+
<!-- Add Text to Stage -->
2406+
<comment userInput="Add Text to Stage" stepKey="commentAddTextToStage"/>
2407+
<actionGroup ref="dragContentTypeToContainer" stepKey="dragTextIntoStage">
24232408
<argument name="contentType" value="PageBuilderTextContentType"/>
24242409
<argument name="containerTargetType" value="PageBuilderRowContentType"/>
2425-
<argument name="containerTargetIndex" value="1"/>
24262410
<argument name="contentTypeIndex" value="1"/>
24272411
</actionGroup>
2428-
<actionGroup ref="clickOutsideTextInlineEditing" stepKey="closeLiveEdit"/>
2412+
<actionGroup ref="dragContentTypeToContainer" stepKey="dragTextIntoStage2">
2413+
<argument name="contentType" value="PageBuilderTextContentType"/>
2414+
<argument name="containerTargetType" value="PageBuilderRowContentType"/>
2415+
<argument name="contentTypeIndex" value="1"/>
2416+
</actionGroup>
2417+
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusEditor"/>
2418+
<!-- Add Padding: Empty -->
2419+
<comment userInput="Add Padding: Empty" stepKey="commentAddPaddingEmpty"/>
24292420
<actionGroup ref="openPageBuilderEditPanelByIndex" stepKey="openEditMenuOnStage1">
24302421
<argument name="contentType" value="PageBuilderTextContentType"/>
24312422
<argument name="contentTypeIndex" value="1"/>
@@ -2437,58 +2428,12 @@
24372428
<argument name="property" value="PageBuilderPaddingPropertyDefault"/>
24382429
</actionGroup>
24392430
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings1"/>
2440-
<!-- Add Padding: 0 -->
2441-
<comment userInput="Add Padding: 0" stepKey="commentAddPadding0"/>
2442-
<actionGroup ref="dragContentTypeToContainer" stepKey="dragTextIntoStage2">
2443-
<argument name="contentType" value="PageBuilderTextContentType"/>
2444-
<argument name="containerTargetType" value="PageBuilderRowContentType"/>
2445-
<argument name="containerTargetIndex" value="2"/>
2446-
<argument name="contentTypeIndex" value="2"/>
2447-
</actionGroup>
2448-
<actionGroup ref="clickOutsideTextInlineEditing" stepKey="closeLiveEdit1"/>
2449-
<actionGroup ref="openPageBuilderEditPanelByIndex" stepKey="openEditMenuOnStage2">
2450-
<argument name="contentType" value="PageBuilderTextContentType"/>
2451-
<argument name="contentTypeIndex" value="2"/>
2452-
</actionGroup>
2453-
<actionGroup ref="addTextToTinyMCE" stepKey="enterText2">
2454-
<argument name="property" value="PageBuilderTextProperty"/>
2455-
</actionGroup>
2456-
<actionGroup ref="fillSlideOutPanelFieldPadding" stepKey="enterPadding2">
2457-
<argument name="property" value="PageBuilderPaddingPropertyDefault"/>
2458-
</actionGroup>
2459-
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings2"/>
2460-
<!-- Add Padding: 1 -->
2461-
<comment userInput="Add Padding: 1" stepKey="commentAddPadding1"/>
2462-
<actionGroup ref="dragContentTypeToContainer" stepKey="dragTextIntoStage3">
2463-
<argument name="contentType" value="PageBuilderTextContentType"/>
2464-
<argument name="containerTargetType" value="PageBuilderRowContentType"/>
2465-
<argument name="containerTargetIndex" value="3"/>
2466-
<argument name="contentTypeIndex" value="3"/>
2467-
</actionGroup>
2468-
<actionGroup ref="clickOutsideTextInlineEditing" stepKey="closeLiveEdit2"/>
2469-
<actionGroup ref="openPageBuilderEditPanelByIndex" stepKey="openEditMenuOnStage3">
2470-
<argument name="contentType" value="PageBuilderTextContentType"/>
2471-
<argument name="contentTypeIndex" value="3"/>
2472-
</actionGroup>
2473-
<actionGroup ref="addTextToTinyMCE" stepKey="enterText3">
2474-
<argument name="property" value="PageBuilderTextProperty"/>
2475-
</actionGroup>
2476-
<actionGroup ref="fillSlideOutPanelFieldPadding" stepKey="enterPadding3">
2477-
<argument name="property" value="PageBuilderPaddingProperty1"/>
2478-
</actionGroup>
2479-
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings3"/>
2431+
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusEditor2"/>
24802432
<!-- Add Padding: Unique -->
24812433
<comment userInput="Add Padding: Unique" stepKey="commentAddPaddingUnique"/>
2482-
<actionGroup ref="dragContentTypeToContainer" stepKey="dragTextIntoStage4">
2483-
<argument name="contentType" value="PageBuilderTextContentType"/>
2484-
<argument name="containerTargetType" value="PageBuilderRowContentType"/>
2485-
<argument name="containerTargetIndex" value="4"/>
2486-
<argument name="contentTypeIndex" value="4"/>
2487-
</actionGroup>
2488-
<actionGroup ref="clickOutsideTextInlineEditing" stepKey="closeLiveEdit3"/>
24892434
<actionGroup ref="openPageBuilderEditPanelByIndex" stepKey="openEditMenuOnStage4">
24902435
<argument name="contentType" value="PageBuilderTextContentType"/>
2491-
<argument name="contentTypeIndex" value="4"/>
2436+
<argument name="contentTypeIndex" value="2"/>
24922437
</actionGroup>
24932438
<actionGroup ref="addTextToTinyMCE" stepKey="enterText4">
24942439
<argument name="property" value="PageBuilderTextProperty"/>
@@ -2497,59 +2442,21 @@
24972442
<argument name="property" value="PageBuilderPaddingPropertyUnique"/>
24982443
</actionGroup>
24992444
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings4"/>
2500-
<!-- Add Padding: Invalid -->
2501-
<comment userInput="Add Padding: Invalid" stepKey="commentAddPaddingInvalid"/>
2502-
<actionGroup ref="dragContentTypeToContainer" stepKey="dragTextIntoStage5">
2503-
<argument name="contentType" value="PageBuilderTextContentType"/>
2504-
<argument name="containerTargetType" value="PageBuilderRowContentType"/>
2505-
<argument name="containerTargetIndex" value="5"/>
2506-
<argument name="contentTypeIndex" value="5"/>
2507-
</actionGroup>
2508-
<actionGroup ref="clickOutsideTextInlineEditing" stepKey="closeLiveEdit4"/>
2509-
<actionGroup ref="openPageBuilderEditPanelByIndex" stepKey="openEditMenuOnStage5">
2510-
<argument name="contentType" value="PageBuilderTextContentType"/>
2511-
<argument name="contentTypeIndex" value="5"/>
2512-
</actionGroup>
2513-
<actionGroup ref="addTextToTinyMCE" stepKey="enterText5">
2514-
<argument name="property" value="PageBuilderTextProperty"/>
2515-
</actionGroup>
2516-
<actionGroup ref="fillSlideOutPanelFieldPadding" stepKey="enterPadding5">
2517-
<argument name="property" value="PageBuilderPaddingPropertyInvalid"/>
2518-
</actionGroup>
2519-
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings5"/>
2445+
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusEditor3"/>
25202446
<!-- Stage: Check Padding: Empty -->
25212447
<comment userInput="Stage: Check Padding: Empty" stepKey="commentStageCheckEmpty"/>
25222448
<actionGroup ref="validateAdvancedStyleWithNoPadding" stepKey="validateStageEmpty">
25232449
<argument name="page" value="TextOnStage"/>
25242450
<argument name="index" value="1"/>
25252451
</actionGroup>
2526-
<!-- Stage: Check Padding: 0 -->
2527-
<comment userInput="Stage: Check Padding: 0" stepKey="commentStageCheck0"/>
2528-
<actionGroup ref="validateAdvancedStyleWithNoAlignment" stepKey="validateStage0">
2529-
<argument name="page" value="TextOnStage"/>
2530-
<argument name="padding" value="PageBuilderPaddingPropertyDefault"/>
2531-
<argument name="index" value="2"/>
2532-
</actionGroup>
2533-
<!-- Stage: Check Padding: 1 -->
2534-
<comment userInput="Stage: Check Padding: 1" stepKey="commentStageCheck1"/>
2535-
<actionGroup ref="validateAdvancedStyleWithNoAlignment" stepKey="validateStage1">
2536-
<argument name="page" value="TextOnStage"/>
2537-
<argument name="padding" value="PageBuilderPaddingProperty1"/>
2538-
<argument name="index" value="3"/>
2539-
</actionGroup>
25402452
<!-- Stage: Check Padding: Unique -->
25412453
<comment userInput="Stage: Check Padding: Unique" stepKey="commentStageCheckUnique"/>
25422454
<actionGroup ref="validateAdvancedStyleWithNoAlignment" stepKey="validateStageUnique">
25432455
<argument name="page" value="TextOnStage"/>
25442456
<argument name="padding" value="PageBuilderPaddingPropertyUnique"/>
2545-
<argument name="index" value="4"/>
2546-
</actionGroup>
2547-
<!-- Stage: Check Padding: Invalid -->
2548-
<comment userInput="Stage: Check Padding: Invalid" stepKey="commentStageCheckInvalid"/>
2549-
<actionGroup ref="validateAdvancedStyleWithNoPadding" stepKey="validateStageInvalid">
2550-
<argument name="page" value="TextOnStage"/>
2551-
<argument name="index" value="5"/>
2457+
<argument name="index" value="2"/>
25522458
</actionGroup>
2459+
<!-- Validate Stage After Save -->
25532460
<comment userInput="Validate Stage After Save" stepKey="commentStageAfterSave"/>
25542461
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage"/>
25552462
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage2"/>
@@ -2559,32 +2466,12 @@
25592466
<argument name="page" value="TextOnStage"/>
25602467
<argument name="index" value="1"/>
25612468
</actionGroup>
2562-
<!-- Stage: Check Padding: 0 -->
2563-
<comment userInput="Stage: Check Padding: 0" stepKey="commentStageCheck02"/>
2564-
<actionGroup ref="validateAdvancedStyleWithNoAlignment" stepKey="validateStage02">
2565-
<argument name="page" value="TextOnStage"/>
2566-
<argument name="padding" value="PageBuilderPaddingPropertyDefault"/>
2567-
<argument name="index" value="2"/>
2568-
</actionGroup>
2569-
<!-- Stage: Check Padding: 1 -->
2570-
<comment userInput="Stage: Check Padding: 1" stepKey="commentStageCheck12"/>
2571-
<actionGroup ref="validateAdvancedStyleWithNoAlignment" stepKey="validateStage12">
2572-
<argument name="page" value="TextOnStage"/>
2573-
<argument name="padding" value="PageBuilderPaddingProperty1"/>
2574-
<argument name="index" value="3"/>
2575-
</actionGroup>
25762469
<!-- Stage: Check Padding: Unique -->
25772470
<comment userInput="Stage: Check Padding: Unique" stepKey="commentStageCheckUnique2"/>
25782471
<actionGroup ref="validateAdvancedStyleWithNoAlignment" stepKey="validateStageUnique2">
25792472
<argument name="page" value="TextOnStage"/>
25802473
<argument name="padding" value="PageBuilderPaddingPropertyUnique"/>
2581-
<argument name="index" value="4"/>
2582-
</actionGroup>
2583-
<!-- Stage: Check Padding: Invalid -->
2584-
<comment userInput="Stage: Check Padding: Invalid" stepKey="commentStageCheckInvalid2"/>
2585-
<actionGroup ref="validateAdvancedStyleWithNoPadding" stepKey="validateStageInvalid2">
2586-
<argument name="page" value="TextOnStage"/>
2587-
<argument name="index" value="5"/>
2474+
<argument name="index" value="2"/>
25882475
</actionGroup>
25892476
<actionGroup ref="navigateToStoreFront" stepKey="navigateToStoreFront">
25902477
<argument name="contentType" value="PageBuilderTextContentType"/>
@@ -2595,32 +2482,12 @@
25952482
<argument name="page" value="TextOnStorefront"/>
25962483
<argument name="index" value="1"/>
25972484
</actionGroup>
2598-
<!-- Storefront: Check Padding: 0 -->
2599-
<comment userInput="Storefront: Check Padding: 0" stepKey="commentStorefrontCheck0"/>
2600-
<actionGroup ref="validateAdvancedStyleWithNoAlignment" stepKey="validateStorefront0">
2601-
<argument name="page" value="TextOnStorefront"/>
2602-
<argument name="padding" value="PageBuilderPaddingPropertyDefault"/>
2603-
<argument name="index" value="2"/>
2604-
</actionGroup>
2605-
<!-- Storefront: Check Padding: 1 -->
2606-
<comment userInput="Storefront: Check Padding: 1" stepKey="commentStorefrontCheck1"/>
2607-
<actionGroup ref="validateAdvancedStyleWithNoAlignment" stepKey="validateStorefront1">
2608-
<argument name="page" value="TextOnStorefront"/>
2609-
<argument name="padding" value="PageBuilderPaddingProperty1"/>
2610-
<argument name="index" value="3"/>
2611-
</actionGroup>
26122485
<!-- Storefront: Check Padding: Unique -->
26132486
<comment userInput="Storefront: Check Padding: Unique" stepKey="commentStorefrontCheckUnique"/>
26142487
<actionGroup ref="validateAdvancedStyleWithNoAlignment" stepKey="validateStorefrontUnique">
26152488
<argument name="page" value="TextOnStorefront"/>
26162489
<argument name="padding" value="PageBuilderPaddingPropertyUnique"/>
2617-
<argument name="index" value="4"/>
2618-
</actionGroup>
2619-
<!-- Storefront: Check Padding: Invalid -->
2620-
<comment userInput="Storefront: Check Padding: Invalid" stepKey="commentStorefrontCheckInvalid"/>
2621-
<actionGroup ref="validateAdvancedStyleWithNoPadding" stepKey="validateStorefrontInvalid">
2622-
<argument name="page" value="TextOnStorefront"/>
2623-
<argument name="index" value="5"/>
2490+
<argument name="index" value="2"/>
26242491
</actionGroup>
26252492
</test>
26262493
<test name="AdvancedConfigurationFunctionalPadding500">

0 commit comments

Comments
 (0)