Skip to content

Commit 8eae47a

Browse files
anthoulaanthoula
committed
MC-3723: Advanced properties saving when invalid value is specified
- add padding invalid cases test
1 parent 93f9ff5 commit 8eae47a

File tree

1 file changed

+223
-3
lines changed

1 file changed

+223
-3
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderAdvancedConfigurationTest.xml

Lines changed: 223 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2154,6 +2154,228 @@
21542154
<argument name="index" value="1"/>
21552155
</actionGroup>
21562156
</test>
2157+
<test name="AdvancedConfigurationInvalidPadding">
2158+
<annotations>
2159+
<features value="PageBuilder"/>
2160+
<stories value="Advanced Configuration"/>
2161+
<title value="Invalid - Padding"/>
2162+
<description value="A user cannot add an invalid value for padding"/>
2163+
<severity value="MAJOR"/>
2164+
<useCaseId value="MAGETWO-83415"/>
2165+
<testCaseId value="MC-4214"/>
2166+
<group value="pagebuilder"/>
2167+
<group value="pagebuilder-advancedConfig"/>
2168+
</annotations>
2169+
<before>
2170+
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
2171+
<actionGroup ref="navigateToAPageWithPageBuilder" stepKey="navigateToAPageWithPageBuilder"/>
2172+
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
2173+
</before>
2174+
<after>
2175+
<actionGroup ref="logout" stepKey="logout"/>
2176+
</after>
2177+
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
2178+
<argument name="contentType" value="PageBuilderTextContentType"/>
2179+
</actionGroup>
2180+
<actionGroup ref="expandPageBuilderPanelGroup" stepKey="expandPageBuilderPanelGroup">
2181+
<argument name="group" value="PageBuilderTextContentType"/>
2182+
</actionGroup>
2183+
<!-- Add Text to Stage -->
2184+
<comment userInput="Add Text to Stage" stepKey="commentAddTextToStage"/>
2185+
<actionGroup ref="dragContentTypeToContainer" stepKey="dragTextIntoStage">
2186+
<argument name="contentType" value="PageBuilderTextContentType"/>
2187+
<argument name="containerTargetType" value="PageBuilderRowContentType"/>
2188+
<argument name="containerTargetIndex" value="1"/>
2189+
<argument name="contentTypeIndex" value="1"/>
2190+
</actionGroup>
2191+
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusEditor"/>
2192+
<actionGroup ref="openPageBuilderEditPanelByIndex" stepKey="openEditMenuOnStage">
2193+
<argument name="contentType" value="PageBuilderTextContentType"/>
2194+
<argument name="contentTypeIndex" value="1"/>
2195+
</actionGroup>
2196+
<actionGroup ref="addTextToTinyMCE" stepKey="enterText">
2197+
<argument name="property" value="PageBuilderTextProperty"/>
2198+
</actionGroup>
2199+
<!-- Add Invalid Padding: NonNumeric - Padding Top -->
2200+
<comment userInput="Add Invalid Padding: NonNumeric - Padding Top" stepKey="commentNonNumericPaddingTop"/>
2201+
<actionGroup ref="fillSlideOutPanelSingleFieldMarginsOrPadding" stepKey="fillNonNumericPaddingTop">
2202+
<argument name="field" value="paddingTop"/>
2203+
<argument name="value" value="{{PageBuilderAdvancedMarginsAndPaddingBoundaryData.invalidString}}"/>
2204+
</actionGroup>
2205+
<actionGroup ref="validateMarginsOrPaddingError" stepKey="validateErrorNonNumericPaddingTop">
2206+
<argument name="property" value="PageBuilderAdvancedMarginsAndPaddingBoundaryData"/>
2207+
<argument name="errorMessage" value="{{PageBuilderAdvancedMarginsAndPaddingBoundaryData.invalidStringError}}"/>
2208+
</actionGroup>
2209+
<actionGroup ref="fillSlideOutPanelSingleFieldMarginsOrPadding" stepKey="clearNonNumericPaddingTop">
2210+
<argument name="field" value="paddingTop"/>
2211+
<argument name="value" value=""/>
2212+
</actionGroup>
2213+
<!-- Add Invalid Padding: NonNumeric - Padding Right -->
2214+
<comment userInput="Add Invalid Padding: NonNumeric - Padding Right" stepKey="commentNonNumericPaddingRight"/>
2215+
<actionGroup ref="fillSlideOutPanelSingleFieldMarginsOrPadding" stepKey="fillNonNumericPaddingRight">
2216+
<argument name="field" value="paddingRight"/>
2217+
<argument name="value" value="{{PageBuilderAdvancedMarginsAndPaddingBoundaryData.invalidString}}"/>
2218+
</actionGroup>
2219+
<actionGroup ref="validateMarginsOrPaddingError" stepKey="validateErrorNonNumericPaddingRight">
2220+
<argument name="property" value="PageBuilderAdvancedMarginsAndPaddingBoundaryData"/>
2221+
<argument name="errorMessage" value="{{PageBuilderAdvancedMarginsAndPaddingBoundaryData.invalidStringError}}"/>
2222+
</actionGroup>
2223+
<actionGroup ref="fillSlideOutPanelSingleFieldMarginsOrPadding" stepKey="clearNonNumericPaddingRight">
2224+
<argument name="field" value="paddingRight"/>
2225+
<argument name="value" value=""/>
2226+
</actionGroup>
2227+
<!-- Add Invalid Padding: NonNumeric - Padding Bottom -->
2228+
<comment userInput="Add Invalid Padding: NonNumeric - Padding Bottom" stepKey="commentNonNumericPaddingBottom"/>
2229+
<actionGroup ref="fillSlideOutPanelSingleFieldMarginsOrPadding" stepKey="fillNonNumericPaddingBottom">
2230+
<argument name="field" value="paddingBottom"/>
2231+
<argument name="value" value="{{PageBuilderAdvancedMarginsAndPaddingBoundaryData.invalidString}}"/>
2232+
</actionGroup>
2233+
<actionGroup ref="validateMarginsOrPaddingError" stepKey="validateErrorNonNumericPaddingBottom">
2234+
<argument name="property" value="PageBuilderAdvancedMarginsAndPaddingBoundaryData"/>
2235+
<argument name="errorMessage" value="{{PageBuilderAdvancedMarginsAndPaddingBoundaryData.invalidStringError}}"/>
2236+
</actionGroup>
2237+
<actionGroup ref="fillSlideOutPanelSingleFieldMarginsOrPadding" stepKey="clearNonNumericPaddingBottom">
2238+
<argument name="field" value="paddingBottom"/>
2239+
<argument name="value" value=""/>
2240+
</actionGroup>
2241+
<!-- Add Invalid Padding: NonNumeric - Padding Left -->
2242+
<comment userInput="Add Invalid Padding: NonNumeric - Padding Left" stepKey="commentNonNumericPaddingLeft"/>
2243+
<actionGroup ref="fillSlideOutPanelSingleFieldMarginsOrPadding" stepKey="fillNonNumericPaddingLeft">
2244+
<argument name="field" value="paddingLeft"/>
2245+
<argument name="value" value="{{PageBuilderAdvancedMarginsAndPaddingBoundaryData.invalidString}}"/>
2246+
</actionGroup>
2247+
<actionGroup ref="validateMarginsOrPaddingError" stepKey="validateErrorNonNumericPaddingLeft">
2248+
<argument name="property" value="PageBuilderAdvancedMarginsAndPaddingBoundaryData"/>
2249+
<argument name="errorMessage" value="{{PageBuilderAdvancedMarginsAndPaddingBoundaryData.invalidStringError}}"/>
2250+
</actionGroup>
2251+
<actionGroup ref="fillSlideOutPanelSingleFieldMarginsOrPadding" stepKey="clearNonNumericPaddingLeft">
2252+
<argument name="field" value="paddingLeft"/>
2253+
<argument name="value" value=""/>
2254+
</actionGroup>
2255+
<!-- Add Invalid Padding: Invalid Min - Padding Top -->
2256+
<comment userInput="Add Invalid Padding: Invalid Min - Padding Top" stepKey="commentInvalidMinPaddingTop"/>
2257+
<actionGroup ref="fillSlideOutPanelSingleFieldMarginsOrPadding" stepKey="fillInvalidMinPaddingTop">
2258+
<argument name="field" value="paddingTop"/>
2259+
<argument name="value" value="{{PageBuilderAdvancedMarginsAndPaddingBoundaryData.invalidMin}}"/>
2260+
</actionGroup>
2261+
<actionGroup ref="validateMarginsOrPaddingError" stepKey="validateErrorInvalidMinPaddingTop">
2262+
<argument name="property" value="PageBuilderAdvancedMarginsAndPaddingBoundaryData"/>
2263+
<argument name="errorMessage" value="{{PageBuilderAdvancedMarginsAndPaddingBoundaryData.invalidMinError}}"/>
2264+
</actionGroup>
2265+
<actionGroup ref="fillSlideOutPanelSingleFieldMarginsOrPadding" stepKey="clearInvalidMinPaddingTop">
2266+
<argument name="field" value="paddingTop"/>
2267+
<argument name="value" value=""/>
2268+
</actionGroup>
2269+
<!-- Add Invalid Padding: Invalid Min - Padding Right -->
2270+
<comment userInput="Add Invalid Padding: Invalid Min - Padding Right" stepKey="commentInvalidMinPaddingRight"/>
2271+
<actionGroup ref="fillSlideOutPanelSingleFieldMarginsOrPadding" stepKey="fillInvalidMinPaddingRight">
2272+
<argument name="field" value="paddingRight"/>
2273+
<argument name="value" value="{{PageBuilderAdvancedMarginsAndPaddingBoundaryData.invalidMin}}"/>
2274+
</actionGroup>
2275+
<actionGroup ref="validateMarginsOrPaddingError" stepKey="validateErrorInvalidMinPaddingRight">
2276+
<argument name="property" value="PageBuilderAdvancedMarginsAndPaddingBoundaryData"/>
2277+
<argument name="errorMessage" value="{{PageBuilderAdvancedMarginsAndPaddingBoundaryData.invalidMinError}}"/>
2278+
</actionGroup>
2279+
<actionGroup ref="fillSlideOutPanelSingleFieldMarginsOrPadding" stepKey="clearInvalidMinPaddingRight">
2280+
<argument name="field" value="paddingRight"/>
2281+
<argument name="value" value=""/>
2282+
</actionGroup>
2283+
<!-- Add Invalid Padding: Invalid Min - Padding Bottom -->
2284+
<comment userInput="Add Invalid Padding: Invalid Min - Padding Bottom" stepKey="commentInvalidMinPaddingBottom"/>
2285+
<actionGroup ref="fillSlideOutPanelSingleFieldMarginsOrPadding" stepKey="fillInvalidMinPaddingBottom">
2286+
<argument name="field" value="paddingBottom"/>
2287+
<argument name="value" value="{{PageBuilderAdvancedMarginsAndPaddingBoundaryData.invalidMin}}"/>
2288+
</actionGroup>
2289+
<actionGroup ref="validateMarginsOrPaddingError" stepKey="validateErrorInvalidMinPaddingBottom">
2290+
<argument name="property" value="PageBuilderAdvancedMarginsAndPaddingBoundaryData"/>
2291+
<argument name="errorMessage" value="{{PageBuilderAdvancedMarginsAndPaddingBoundaryData.invalidMinError}}"/>
2292+
</actionGroup>
2293+
<actionGroup ref="fillSlideOutPanelSingleFieldMarginsOrPadding" stepKey="clearInvalidMinPaddingBottom">
2294+
<argument name="field" value="paddingBottom"/>
2295+
<argument name="value" value=""/>
2296+
</actionGroup>
2297+
<!-- Add Invalid Padding: Invalid Min - Padding Left -->
2298+
<comment userInput="Add Invalid Padding: Invalid Min - Padding Left" stepKey="commentInvalidMinPaddingLeft"/>
2299+
<actionGroup ref="fillSlideOutPanelSingleFieldMarginsOrPadding" stepKey="fillInvalidMinPaddingLeft">
2300+
<argument name="field" value="paddingLeft"/>
2301+
<argument name="value" value="{{PageBuilderAdvancedMarginsAndPaddingBoundaryData.invalidMin}}"/>
2302+
</actionGroup>
2303+
<actionGroup ref="validateMarginsOrPaddingError" stepKey="validateErrorInvalidMinPaddingLeft">
2304+
<argument name="property" value="PageBuilderAdvancedMarginsAndPaddingBoundaryData"/>
2305+
<argument name="errorMessage" value="{{PageBuilderAdvancedMarginsAndPaddingBoundaryData.invalidMinError}}"/>
2306+
</actionGroup>
2307+
<actionGroup ref="fillSlideOutPanelSingleFieldMarginsOrPadding" stepKey="clearInvalidMinPaddingLeft">
2308+
<argument name="field" value="paddingLeft"/>
2309+
<argument name="value" value=""/>
2310+
</actionGroup>
2311+
<!-- Add Invalid Padding: Invalid Max - Padding Top -->
2312+
<comment userInput="Add Invalid Padding: Invalid Max - Padding Top" stepKey="commentInvalidMaxPaddingTop"/>
2313+
<actionGroup ref="fillSlideOutPanelSingleFieldMarginsOrPadding" stepKey="fillInvalidMaxPaddingTop">
2314+
<argument name="field" value="paddingTop"/>
2315+
<argument name="value" value="{{PageBuilderAdvancedMarginsAndPaddingBoundaryData.invalidMax}}"/>
2316+
</actionGroup>
2317+
<actionGroup ref="validateMarginsOrPaddingError" stepKey="validateErrorInvalidMaxPaddingTop">
2318+
<argument name="property" value="PageBuilderAdvancedMarginsAndPaddingBoundaryData"/>
2319+
<argument name="errorMessage" value="{{PageBuilderAdvancedMarginsAndPaddingBoundaryData.invalidMaxError}}"/>
2320+
</actionGroup>
2321+
<actionGroup ref="fillSlideOutPanelSingleFieldMarginsOrPadding" stepKey="clearInvalidMaxPaddingTop">
2322+
<argument name="field" value="paddingTop"/>
2323+
<argument name="value" value=""/>
2324+
</actionGroup>
2325+
<!-- Add Invalid Padding: Invalid Max - Padding Right -->
2326+
<comment userInput="Add Invalid Padding: Invalid Max - Padding Right" stepKey="commentInvalidMaxPaddingRight"/>
2327+
<actionGroup ref="fillSlideOutPanelSingleFieldMarginsOrPadding" stepKey="fillInvalidMaxPaddingRight">
2328+
<argument name="field" value="paddingRight"/>
2329+
<argument name="value" value="{{PageBuilderAdvancedMarginsAndPaddingBoundaryData.invalidMax}}"/>
2330+
</actionGroup>
2331+
<actionGroup ref="validateMarginsOrPaddingError" stepKey="validateErrorInvalidMaxPaddingRight">
2332+
<argument name="property" value="PageBuilderAdvancedMarginsAndPaddingBoundaryData"/>
2333+
<argument name="errorMessage" value="{{PageBuilderAdvancedMarginsAndPaddingBoundaryData.invalidMaxError}}"/>
2334+
</actionGroup>
2335+
<actionGroup ref="fillSlideOutPanelSingleFieldMarginsOrPadding" stepKey="clearInvalidMaxPaddingRight">
2336+
<argument name="field" value="paddingRight"/>
2337+
<argument name="value" value=""/>
2338+
</actionGroup>
2339+
<!-- Add Invalid Padding: Invalid Max - Padding Bottom -->
2340+
<comment userInput="Add Invalid Padding: Invalid Max - Padding Bottom" stepKey="commentInvalidMaxPaddingBottom"/>
2341+
<actionGroup ref="fillSlideOutPanelSingleFieldMarginsOrPadding" stepKey="fillInvalidMaxPaddingBottom">
2342+
<argument name="field" value="paddingBottom"/>
2343+
<argument name="value" value="{{PageBuilderAdvancedMarginsAndPaddingBoundaryData.invalidMax}}"/>
2344+
</actionGroup>
2345+
<actionGroup ref="validateMarginsOrPaddingError" stepKey="validateErrorInvalidMaxPaddingBottom">
2346+
<argument name="property" value="PageBuilderAdvancedMarginsAndPaddingBoundaryData"/>
2347+
<argument name="errorMessage" value="{{PageBuilderAdvancedMarginsAndPaddingBoundaryData.invalidMaxError}}"/>
2348+
</actionGroup>
2349+
<actionGroup ref="fillSlideOutPanelSingleFieldMarginsOrPadding" stepKey="clearInvalidMaxPaddingBottom">
2350+
<argument name="field" value="paddingBottom"/>
2351+
<argument name="value" value=""/>
2352+
</actionGroup>
2353+
<!-- Add Invalid Padding: Invalid Max - Padding Left -->
2354+
<comment userInput="Add Invalid Padding: Invalid Max - Padding Left" stepKey="commentInvalidMaxPaddingLeft"/>
2355+
<actionGroup ref="fillSlideOutPanelSingleFieldMarginsOrPadding" stepKey="fillInvalidMaxPaddingLeft">
2356+
<argument name="field" value="paddingLeft"/>
2357+
<argument name="value" value="{{PageBuilderAdvancedMarginsAndPaddingBoundaryData.invalidMax}}"/>
2358+
</actionGroup>
2359+
<actionGroup ref="validateMarginsOrPaddingError" stepKey="validateErrorInvalidMaxPaddingLeft">
2360+
<argument name="property" value="PageBuilderAdvancedMarginsAndPaddingBoundaryData"/>
2361+
<argument name="errorMessage" value="{{PageBuilderAdvancedMarginsAndPaddingBoundaryData.invalidMaxError}}"/>
2362+
</actionGroup>
2363+
<actionGroup ref="fillSlideOutPanelSingleFieldMarginsOrPadding" stepKey="clearInvalidMaxPaddingLeft">
2364+
<argument name="field" value="paddingLeft"/>
2365+
<argument name="value" value=""/>
2366+
</actionGroup>
2367+
<!-- User can recover after invalid input -->
2368+
<comment userInput="User can recover after invalid input" stepKey="commentCanRecover"/>
2369+
<actionGroup ref="fillSlideOutPanelFieldPadding" stepKey="enterPadding">
2370+
<argument name="property" value="PageBuilderPaddingPropertyDefault"/>
2371+
</actionGroup>
2372+
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
2373+
<actionGroup ref="validateAdvancedStyleWithNoAlignment" stepKey="validateStage">
2374+
<argument name="page" value="TextOnStage"/>
2375+
<argument name="padding" value="PageBuilderPaddingPropertyDefault"/>
2376+
<argument name="index" value="1"/>
2377+
</actionGroup>
2378+
</test>
21572379
<test name="AdvancedConfigurationFunctionalPadding">
21582380
<annotations>
21592381
<features value="PageBuilder"/>
@@ -2164,10 +2386,8 @@
21642386
<useCaseId value="MAGETWO-83415"/>
21652387
<testCaseId value="MC-2611"/>
21662388
<group value="pagebuilder"/>
2389+
<group value="pagebuilder-me"/>
21672390
<group value="pagebuilder-advancedConfig"/>
2168-
<skip>
2169-
<issueId value="MC-3723"/>
2170-
</skip>
21712391
</annotations>
21722392
<before>
21732393
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>

0 commit comments

Comments
 (0)