Skip to content

Commit 7049462

Browse files
committed
MC-5474: Anchor tag name is used on banner/slide/image wrapper when no link is specified by admin
Update expected HTML output for DataConverter test
1 parent bf44d53 commit 7049462

10 files changed

+10
-10
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<div data-element="main" data-role="row" data-appearance="contained"><div data-element="inner"><div data-element="main" data-role="slider" data-appearance="default" data-autoplay="0" data-autoplay-speed="0" data-fade="0" data-is-infinite="0" data-show-arrows="0" data-show-dots="0" class="one two pagebuilder-slider" style="text-align: left; margin: 2px 3px 4px 1px; padding: 6px 7px 8px 5px;"><div data-element="main" data-role="slide" data-appearance="poster" class="one two" style="margin: 2px 3px 4px 1px;"><div data-element="link" href="http://domain.com/"><div data-element="wrapper" data-background-images="{}" class="pagebuilder-slide-wrapper" style="text-align: left; margin: 2px 3px 4px 1px; padding: 6px 7px 8px 5px;"><div data-element="overlay" class="pagebuilder-overlay pagebuilder-poster-overlay" data-overlay-color="transparent" style="padding: 6px 7px 8px 5px;"><div class="pagebuilder-poster-content"><div data-element="content"><h3>Slide title</h3><div><p>Slide <strong>content</strong></p></div></div><button data-element="button" type="button" class="pagebuilder-slide-button pagebuilder-button-primary" style="opacity: 1; visibility: visible;">Domain</button></div></div></div></div></div></div></div></div>
1+
<div data-element="main" data-role="row" data-appearance="contained"><div data-element="inner"><div data-element="main" data-role="slider" data-appearance="default" data-autoplay="0" data-autoplay-speed="0" data-fade="0" data-is-infinite="0" data-show-arrows="0" data-show-dots="0" class="one two pagebuilder-slider" style="text-align: left; margin: 2px 3px 4px 1px; padding: 6px 7px 8px 5px;"><div data-element="main" data-role="slide" data-appearance="poster" class="one two" style="margin: 2px 3px 4px 1px;"><a data-element="link" href="http://domain.com/"><div data-element="wrapper" data-background-images="{}" class="pagebuilder-slide-wrapper" style="text-align: left; margin: 2px 3px 4px 1px; padding: 6px 7px 8px 5px;"><div data-element="overlay" class="pagebuilder-overlay pagebuilder-poster-overlay" data-overlay-color="transparent" style="padding: 6px 7px 8px 5px;"><div class="pagebuilder-poster-content"><div data-element="content"><h3>Slide title</h3><div><p>Slide <strong>content</strong></p></div></div><button data-element="button" type="button" class="pagebuilder-slide-button pagebuilder-button-primary" style="opacity: 1; visibility: visible;">Domain</button></div></div></div></a></div></div></div></div>
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<div data-element="main" data-role="row" data-appearance="contained"><div data-element="inner"><div data-element="main" data-role="slider" data-appearance="default" data-autoplay="1" data-autoplay-speed="500" data-fade="0" data-is-infinite="0" data-show-arrows="1" data-show-dots="0" class="one two pagebuilder-slider"><div data-element="main" data-role="slide" data-appearance="poster" class="one two"><div data-element="link" href="http://domain.com/"><div data-element="wrapper" data-background-images="{\&quot;desktop_image\&quot;:\&quot;{{media url=wysiwyg/m/a/magento.png}}\&quot;,\&quot;mobile_image\&quot;:\&quot;{}\&quot;}" class="pagebuilder-slide-wrapper"><div data-element="overlay" class="pagebuilder-overlay pagebuilder-poster-overlay" data-overlay-color="transparent"><div class="pagebuilder-poster-content"><div data-element="content"><h3>Slide title</h3><div><p>Slide <strong>content</strong></p></div></div><button data-element="button" type="button" class="pagebuilder-slide-button pagebuilder-button-primary" style="opacity: 1; visibility: visible;">Domain</button></div></div></div></div></div></div></div></div>
1+
<div data-element="main" data-role="row" data-appearance="contained"><div data-element="inner"><div data-element="main" data-role="slider" data-appearance="default" data-autoplay="1" data-autoplay-speed="500" data-fade="0" data-is-infinite="0" data-show-arrows="1" data-show-dots="0" class="one two pagebuilder-slider"><div data-element="main" data-role="slide" data-appearance="poster" class="one two"><a data-element="link" href="http://domain.com/"><div data-element="wrapper" data-background-images="{\&quot;desktop_image\&quot;:\&quot;{{media url=wysiwyg/m/a/magento.png}}\&quot;,\&quot;mobile_image\&quot;:\&quot;{}\&quot;}" class="pagebuilder-slide-wrapper"><div data-element="overlay" class="pagebuilder-overlay pagebuilder-poster-overlay" data-overlay-color="transparent"><div class="pagebuilder-poster-content"><div data-element="content"><h3>Slide title</h3><div><p>Slide <strong>content</strong></p></div></div><button data-element="button" type="button" class="pagebuilder-slide-button pagebuilder-button-primary" style="opacity: 1; visibility: visible;">Domain</button></div></div></div></a></div></div></div></div>
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<div data-element="main" data-role="row" data-appearance="contained"><div data-element="inner"><div data-element="main" data-role="slider" data-appearance="default" data-autoplay="1" data-autoplay-speed="500" data-fade="0" data-is-infinite="0" data-show-arrows="1" data-show-dots="0" class="pagebuilder-slider"><div data-element="main" data-role="slide" data-appearance="poster"><div data-element="link" href="http://domain.com/"><div data-element="wrapper" data-background-images="{}" class="pagebuilder-slide-wrapper"><div data-element="overlay" class="pagebuilder-overlay pagebuilder-poster-overlay" data-overlay-color="transparent"><div class="pagebuilder-poster-content"><div data-element="content"><h3>Slide title</h3><div><p>Slide <strong>content</strong></p></div></div></div></div></div></div></div></div></div></div>
1+
<div data-element="main" data-role="row" data-appearance="contained"><div data-element="inner"><div data-element="main" data-role="slider" data-appearance="default" data-autoplay="1" data-autoplay-speed="500" data-fade="0" data-is-infinite="0" data-show-arrows="1" data-show-dots="0" class="pagebuilder-slider"><div data-element="main" data-role="slide" data-appearance="poster"><a data-element="link" href="http://domain.com/"><div data-element="wrapper" data-background-images="{}" class="pagebuilder-slide-wrapper"><div data-element="overlay" class="pagebuilder-overlay pagebuilder-poster-overlay" data-overlay-color="transparent"><div class="pagebuilder-poster-content"><div data-element="content"><h3>Slide title</h3><div><p>Slide <strong>content</strong></p></div></div></div></div></div></a></div></div></div></div>
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<div data-element="main" data-role="row" data-appearance="contained"><div data-element="inner"><div data-element="main" data-role="slider" data-appearance="default" data-autoplay="1" data-autoplay-speed="500" data-fade="0" data-is-infinite="0" data-show-arrows="1" data-show-dots="0" class="pagebuilder-slider"><div data-element="main" data-role="slide" data-appearance="poster"><div data-element="link" href="http://domain.com/"><div data-element="wrapper" data-background-images="{}" class="pagebuilder-slide-wrapper"><div data-element="overlay" class="pagebuilder-overlay pagebuilder-poster-overlay" data-overlay-color="rgba(0,0,0,0.5)" style="background-color: rgba(0,0,0,0.5);"><div class="pagebuilder-poster-content"><div data-element="content"><h3>Slide title</h3><div><p>Slide <strong>content</strong></p></div></div></div></div></div></div></div></div></div></div>
1+
<div data-element="main" data-role="row" data-appearance="contained"><div data-element="inner"><div data-element="main" data-role="slider" data-appearance="default" data-autoplay="1" data-autoplay-speed="500" data-fade="0" data-is-infinite="0" data-show-arrows="1" data-show-dots="0" class="pagebuilder-slider"><div data-element="main" data-role="slide" data-appearance="poster"><a data-element="link" href="http://domain.com/"><div data-element="wrapper" data-background-images="{}" class="pagebuilder-slide-wrapper"><div data-element="overlay" class="pagebuilder-overlay pagebuilder-poster-overlay" data-overlay-color="rgba(0,0,0,0.5)" style="background-color: rgba(0,0,0,0.5);"><div class="pagebuilder-poster-content"><div data-element="content"><h3>Slide title</h3><div><p>Slide <strong>content</strong></p></div></div></div></div></div></a></div></div></div></div>
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<div data-element="main" data-role="row" data-appearance="contained"><div data-element="inner"><div data-element="main" data-role="banner" data-appearance="poster" data-show-button="always" data-show-overlay="never" class="one two" style="background-size: auto; background-repeat: no-repeat; background-attachment: scroll; border: 1px none; border-radius: 0px; margin: 2px 3px 4px 1px;"><div data-element="link" href="http://domain.com/"><div data-element="wrapper" data-background-images="{\&quot;desktop_image\&quot;:\&quot;{{media url=wysiwyg/m/a/magento.png}}\&quot;,\&quot;mobile_image\&quot;:\&quot;{{media url=wysiwyg/m/a/magento.png}}\&quot;}" style="min-height: 300px; background-size: auto; background-repeat: no-repeat; background-attachment: scroll; text-align: left;" class="pagebuilder-banner-wrapper"><div data-element="overlay" class="pagebuilder-poster-overlay" data-overlay-color="transparent" style="background-color: transparent; min-height: 300px; padding: 6px 7px 8px 5px;"><div class="pagebuilder-poster-content"><div data-element="content"></div><button data-element="button" class="pagebuilder-banner-button pagebuilder-button-primary" style="visibility: visible; opacity: 1;">Link Text</button></div></div></div><div data-element="overlay" class="pagebuilder-poster-overlay" data-overlay-color="transparent" style="background-color: transparent; min-height: 300px; padding: 6px 7px 8px 5px;"><div class="pagebuilder-poster-content"><div data-element="content"></div><button data-element="button" class="pagebuilder-banner-button pagebuilder-button-primary" style="visibility: visible; opacity: 1;">Link Text</button></div></div></div></div></div></div></div>
1+
<div data-element="main" data-role="row" data-appearance="contained"><div data-element="inner"><div data-element="main" data-role="banner" data-appearance="poster" data-show-button="always" data-show-overlay="never" class="one two" style="background-size: auto; background-repeat: no-repeat; background-attachment: scroll; border: 1px none; border-radius: 0px; margin: 2px 3px 4px 1px;"><a data-element="link" href="http://domain.com/"><div data-element="wrapper" data-background-images="{\&quot;desktop_image\&quot;:\&quot;{{media url=wysiwyg/m/a/magento.png}}\&quot;,\&quot;mobile_image\&quot;:\&quot;{{media url=wysiwyg/m/a/magento.png}}\&quot;}" style="min-height: 300px; background-size: auto; background-repeat: no-repeat; background-attachment: scroll; text-align: left;" class="pagebuilder-banner-wrapper"><div data-element="overlay" class="pagebuilder-poster-overlay" data-overlay-color="transparent" style="background-color: transparent; min-height: 300px; padding: 6px 7px 8px 5px;"><div class="pagebuilder-poster-content"><div data-element="content"></div><button data-element="button" class="pagebuilder-banner-button pagebuilder-button-primary" style="visibility: visible; opacity: 1;">Link Text</button></div></div></div><div data-element="overlay" class="pagebuilder-poster-overlay" data-overlay-color="transparent" style="background-color: transparent; min-height: 300px; padding: 6px 7px 8px 5px;"><div class="pagebuilder-poster-content"><div data-element="content"></div><button data-element="button" class="pagebuilder-banner-button pagebuilder-button-primary" style="visibility: visible; opacity: 1;">Link Text</button></div></div></div></a></div></div></div>
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<div data-element="main" data-role="row" data-appearance="contained"><div data-element="inner"><div data-element="main" data-role="banner" data-appearance="poster" data-show-button="never" data-show-overlay="never" class="one two" style="background-size: auto; background-repeat: no-repeat; background-attachment: scroll; border: 1px none; border-radius: 0px; margin: 0px;"><div data-element="link" href="http://domain.com/"><div data-element="wrapper" data-background-images="{\&quot;desktop_image\&quot;:\&quot;{{media url=wysiwyg/m/a/magento1.png}}\&quot;,\&quot;mobile_image\&quot;:\&quot;{{media url=wysiwyg/m/a/magento1.png}}\&quot;}" style="min-height: 300px; background-size: auto; background-repeat: no-repeat; background-attachment: scroll;" class="pagebuilder-banner-wrapper"><div data-element="overlay" class="pagebuilder-poster-overlay" data-overlay-color="transparent" style="background-color: transparent; min-height: 300px; padding: 40px;"><div class="pagebuilder-poster-content"><div data-element="content"></div></div></div></div><div data-element="overlay" class="pagebuilder-poster-overlay" data-overlay-color="transparent" style="background-color: transparent; min-height: 300px; padding: 40px;"><div class="pagebuilder-poster-content"><div data-element="content"></div></div></div></div></div></div></div></div>
1+
<div data-element="main" data-role="row" data-appearance="contained"><div data-element="inner"><div data-element="main" data-role="banner" data-appearance="poster" data-show-button="never" data-show-overlay="never" class="one two" style="background-size: auto; background-repeat: no-repeat; background-attachment: scroll; border: 1px none; border-radius: 0px; margin: 0px;"><a data-element="link" href="http://domain.com/"><div data-element="wrapper" data-background-images="{\&quot;desktop_image\&quot;:\&quot;{{media url=wysiwyg/m/a/magento1.png}}\&quot;,\&quot;mobile_image\&quot;:\&quot;{{media url=wysiwyg/m/a/magento1.png}}\&quot;}" style="min-height: 300px; background-size: auto; background-repeat: no-repeat; background-attachment: scroll;" class="pagebuilder-banner-wrapper"><div data-element="overlay" class="pagebuilder-poster-overlay" data-overlay-color="transparent" style="background-color: transparent; min-height: 300px; padding: 40px;"><div class="pagebuilder-poster-content"><div data-element="content"></div></div></div></div><div data-element="overlay" class="pagebuilder-poster-overlay" data-overlay-color="transparent" style="background-color: transparent; min-height: 300px; padding: 40px;"><div class="pagebuilder-poster-content"><div data-element="content"></div></div></div></div></a></div></div></div>
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<div data-element="main" data-role="row" data-appearance="contained"><div data-element="inner"><div data-element="main" data-role="banner" data-appearance="poster" data-show-button="never" data-show-overlay="never" class="one two" style="background-size: auto; background-repeat: no-repeat; background-attachment: scroll; border: 1px none; border-radius: 0px; margin: 0px;"><div data-element="link" href="http://domain.com/" target="_blank"><div data-element="wrapper" data-background-images="{\&quot;desktop_image\&quot;:\&quot;{{media url=wysiwyg/m/a/magento1.png}}\&quot;,\&quot;mobile_image\&quot;:\&quot;{{media url=wysiwyg/m/a/magento1.png}}\&quot;}" style="min-height: 300px; background-size: auto; background-repeat: no-repeat; background-attachment: scroll;" class="pagebuilder-banner-wrapper"><div data-element="overlay" class="pagebuilder-poster-overlay" data-overlay-color="transparent" style="background-color: transparent; min-height: 300px; padding: 40px;"><div class="pagebuilder-poster-content"><div data-element="content"></div></div></div></div><div data-element="overlay" class="pagebuilder-poster-overlay" data-overlay-color="transparent" style="background-color: transparent; min-height: 300px; padding: 40px;"><div class="pagebuilder-poster-content"><div data-element="content"></div></div></div></div></div></div></div></div>
1+
<div data-element="main" data-role="row" data-appearance="contained"><div data-element="inner"><div data-element="main" data-role="banner" data-appearance="poster" data-show-button="never" data-show-overlay="never" class="one two" style="background-size: auto; background-repeat: no-repeat; background-attachment: scroll; border: 1px none; border-radius: 0px; margin: 0px;"><a data-element="link" href="http://domain.com/" target="_blank"><div data-element="wrapper" data-background-images="{\&quot;desktop_image\&quot;:\&quot;{{media url=wysiwyg/m/a/magento1.png}}\&quot;,\&quot;mobile_image\&quot;:\&quot;{{media url=wysiwyg/m/a/magento1.png}}\&quot;}" style="min-height: 300px; background-size: auto; background-repeat: no-repeat; background-attachment: scroll;" class="pagebuilder-banner-wrapper"><div data-element="overlay" class="pagebuilder-poster-overlay" data-overlay-color="transparent" style="background-color: transparent; min-height: 300px; padding: 40px;"><div class="pagebuilder-poster-content"><div data-element="content"></div></div></div></div><div data-element="overlay" class="pagebuilder-poster-overlay" data-overlay-color="transparent" style="background-color: transparent; min-height: 300px; padding: 40px;"><div class="pagebuilder-poster-content"><div data-element="content"></div></div></div></div></a></div></div></div>
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<div data-element="main" data-role="row" data-appearance="contained"><div data-element="inner"><div data-element="main" data-role="buttons" data-appearance="inline" style="display: inline-block; text-align: left; margin: 2px 3px 4px 1px; padding: 6px 7px 8px 5px;"><div data-element="main" data-role="button-item" data-appearance="default" style="display: inline-block;"><a data-element="link" href="" style="text-align: right; margin: 0px 2px 0px 1px; padding: 3px 0px 4px 0px;" class="pagebuilder-button-primary"><span data-element="link_text">Domain.com</span></a></div></div></div></div>
1+
<div data-element="main" data-role="row" data-appearance="contained"><div data-element="inner"><div data-element="main" data-role="buttons" data-appearance="inline" style="display: inline-block; text-align: left; margin: 2px 3px 4px 1px; padding: 6px 7px 8px 5px;"><div data-element="main" data-role="button-item" data-appearance="default" style="display: inline-block;"><div data-element="link" style="text-align: right; margin: 0px 2px 0px 1px; padding: 3px 0px 4px 0px;" class="pagebuilder-button-primary"><span data-element="link_text">Domain.com</span></div></div></div></div></div>

0 commit comments

Comments
 (0)