Skip to content

Commit ab5f293

Browse files
committed
MC-3228: Add Missing P0-P1 MFTF Tests For Slider
- Adding tests for moving slider & duplicating slider - Moving tests between files - Updating supporting data and selectors
1 parent 1106050 commit ab5f293

File tree

5 files changed

+1065
-764
lines changed

5 files changed

+1065
-764
lines changed

app/code/Magento/PageBuilder/Test/Mftf/Data/SlideData.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
<data key="value">Slide 2 Name</data>
2929
</entity>
3030
<!-- Minimum Height -->
31-
<!--todo: use shared data-->
3231
<entity name="PageBuilderSlideItemMinimumHeight_500" type="pagebuilder_slide_item_minimum_height_property">
3332
<data key="name">Minimum Height</data>
3433
<data key="section">appearance_fieldset</data>

app/code/Magento/PageBuilder/Test/Mftf/Data/SliderData.xml

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,6 @@
2828
<data key="fieldName">autoplay_speed</data>
2929
<data key="value">4000</data>
3030
</entity>
31-
<entity name="PageBuilderSliderAutoPlaySpeed_5000" type="pagebuilder_slider_autoplay_speed_property">
32-
<data key="name">Autoplay Speed</data>
33-
<data key="section">settings</data>
34-
<data key="fieldName">autoplay_speed</data>
35-
<data key="value">5000</data>
36-
</entity>
3731
<entity name="PageBuilderSliderAutoPlaySpeed_50000" type="pagebuilder_slider_autoplay_speed_property">
3832
<data key="name">Autoplay Speed</data>
3933
<data key="section">settings</data>
@@ -99,11 +93,11 @@
9993
<data key="fieldName">min_height</data>
10094
<data key="value">300</data>
10195
</entity>
102-
<entity name="PageBuilderSliderMinHeight_500" type="pagebuilder_slider_min_height_property">
96+
<entity name="PageBuilderSliderMinHeight_100" type="pagebuilder_slider_min_height_property">
10397
<data key="name">Minimum Height</data>
10498
<data key="section">settings</data>
10599
<data key="fieldName">min_height</data>
106-
<data key="value">500</data>
100+
<data key="value">100</data>
107101
</entity>
108102
<!-- Container Height -->
109103
<entity name="PageBuilderEmptySliderContainerHeight" type="pagebuilder_slider_height_property">

app/code/Magento/PageBuilder/Test/Mftf/Section/PageBuilderSliderSection.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,13 +38,13 @@
3838
<element name="all" type="button" selector="div[data-role=slider]"/>
3939
<element name="base" type="button" selector="(//div[@data-role='slider'])[{{arg1}}]" parameterized="true"/>
4040
<element name="hidden" type="button" selector="(//div[@data-role='slider'])[{{arg1}}]/ancestor::*[contains(@class, 'pagebuilder-content-type-wrapper') and contains(@class, 'pagebuilder-content-type-hidden')]" parameterized="true"/>
41+
<!--todo: below is not valid-->
4142
<element name="notHidden" type="button" selector="(//div[@data-role='slider'])[{{arg1}}]/ancestor::*[contains(@class, 'pagebuilder-content-type-wrapper') and not(contains(@class, 'pagebuilder-content-type-hidden'))][1]" parameterized="true"/>
4243
<element name="slideNavigationDot" type="button" selector="(//div[@data-role='slider'])[{{arg1}}]//div[contains(@class,'navigation-dot')][{{arg2}}]" parameterized="true"/>
4344
<element name="activeSlideNavigationDot" type="button" selector="div.navigation-dot.active"/>
4445
<element name="slideNavigationDotNameTooltip" type="button" selector="(//div[@data-role='slider'])[{{arg1}}]//span[@role='tooltip']" parameterized="true"/>
4546
<element name="slideNavigationDragHandle" type="button" selector="a.navigation-dot-anchor"/>
4647
<element name="slideNavigationDragHandleByIndex" type="button" selector="((//div[@data-role='slider'])[{{arg1}}]//a[contains(@class,'navigation-dot-anchor')])[{{arg2}}]" parameterized="true"/>
47-
<element name="sliderContainer" type="button" selector="div.element-children.slider-container"/>
4848
<!-- Settings Configuration -->
4949
<element name="autoPlay" type="button" selector="(//div[@data-role='slider'])[{{arg1}}][@data-autoplay='{{arg2}}']" parameterized="true"/>
5050
<element name="autoPlaySpeed" type="button" selector="(//div[@data-role='slider'])[{{arg1}}][@data-autoplay-speed='{{arg2}}']" parameterized="true"/>

0 commit comments

Comments
 (0)