Skip to content

Commit b22bff5

Browse files
committed
MC-3095: Display TypeScript errors within local build process
- Resolve errors in property pool - Add new function to open edit form
1 parent e1ffefc commit b22bff5

File tree

19 files changed

+66
-26
lines changed

19 files changed

+66
-26
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/block/preview.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/map/preview.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/preview.js

Lines changed: 9 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/products/preview.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/content-type/video/preview.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/property/property-reader-pool-factory.js

Lines changed: 5 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/js/property/property-reader-pool.js

Lines changed: 3 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type-config.d.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ export interface DataMappingInterface {
5555
export interface DataMappingStyleInterface {
5656
var?: string;
5757
name: string;
58+
reader?: string;
5859
value?: string;
5960
converter?: string;
6061
preview_converter?: string;

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/block/preview.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ export default class Preview extends BasePreview {
5050
events.on("block:dropAfter", (args: ContentTypeDroppedCreateEventParamsInterface) => {
5151
if (args.id === this.parent.id) {
5252
setTimeout(() => {
53-
this.edit.open();
53+
this.openEdit();
5454
}, 300);
5555
}
5656
});

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/content-type/map/preview.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ export default class Preview extends BasePreview {
3333
events.on("map:dropAfter", (args: ContentTypeDroppedCreateEventParamsInterface) => {
3434
if (args.id === this.parent.id) {
3535
setTimeout(() => {
36-
this.edit.open();
36+
this.openEdit();
3737
}, 300);
3838
}
3939
});

0 commit comments

Comments
 (0)