MC-3695: Remove Newsletter

krissyhiserote · krissyhiserote · commit de6dcb1a0e6a · 2018-08-27T14:39:36.000-05:00
- fix minor issues and remove newsletter from composer.json
diff --git a/app/code/Magento/PageBuilder/Setup/DataConverter/Renderer/Newsletter.php b/app/code/Magento/PageBuilder/Setup/DataConverter/Renderer/Newsletter.php
@@ -51,7 +51,7 @@ public function render(array $itemData, array $additionalData = []) : string
     }
 
     /**
-     * get the html for the newsletter
+     * Get the html for the newsletter
      *
      * @param array $itemData
      * @param array $eavData
@@ -105,7 +105,6 @@ private function getNewsletterHtml(array $itemData, array $eavData): string
             '</button>' .
             '</div></form></div></div></div>';
 
-
         return $newsletterHtml;
     }
 }
diff --git a/app/code/Magento/PageBuilder/composer.json b/app/code/Magento/PageBuilder/composer.json
@@ -11,7 +11,6 @@
         "magento/module-config": "*",
         "magento/module-ui": "*",
         "magento/module-search": "*",
-        "magento/module-newsletter": "*",
         "magento/module-widget": "*",
         "magento/module-catalog-widget": "*",
         "magento/module-rule": "*",

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ public function render(array $itemData, array $additionalData = []) : string`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`/**`
`54`		`- * get the html for the newsletter`
	`54`	`+ * Get the html for the newsletter`
`55`	`55`	`*`
`56`	`56`	`* @param array $itemData`
`57`	`57`	`* @param array $eavData`
`@@ -105,7 +105,6 @@ private function getNewsletterHtml(array $itemData, array $eavData): string`
`105`	`105`	`'</button>' .`
`106`	`106`	`'</div></form></div></div></div>';`
`107`	`107`
`108`		`-`
`109`	`108`	`return $newsletterHtml;`
`110`	`109`	`}`
`111`	`110`	`}`