Skip to content

Commit e412b26

Browse files
committed
MC-3723: Advanced properties saving when invalid value is specified
- update useCaseId - add inline comments - update stepKeys
1 parent 6874517 commit e412b26

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/AdvancedConfigurationActionGroup.xml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
<argument name="field" type="string"/>
2525
<argument name="value" type="string"/>
2626
</arguments>
27-
<waitForElement selector="{{AdvancedForm.advancedMarginsOrPaddingField(field)}}" stepKey="waitForElementVisible"/>
27+
<waitForElement selector="{{AdvancedForm.advancedMarginsOrPaddingField(field)}}" stepKey="waitForElement"/>
2828
<fillField selector="{{AdvancedForm.advancedMarginsOrPaddingField(field)}}" userInput="{{value}}" stepKey="fillFieldMarginOrPadding"/>
2929
</actionGroup>
3030
<actionGroup name="validateMarginsOrPaddingError">
@@ -33,7 +33,8 @@
3333
<argument name="errorMessage" type="string"/>
3434
</arguments>
3535
<waitForElementVisible selector="{{EditPanelForm.panelSectionError(property.section)}}" stepKey="waitForSectionChangedIcon"/>
36-
<see userInput="{{errorMessage}}" selector="{{AdvancedForm.advancedMarginAndPaddingErrorMessage}}" stepKey="waitForErrorMessage"/>
36+
<seeElement selector="{{EditPanelForm.panelSectionError(property.section)}}" stepKey="seeElementSectionChangedIcon"/>
37+
<see userInput="{{errorMessage}}" selector="{{AdvancedForm.advancedMarginAndPaddingErrorMessage}}" stepKey="seeErrorMessage"/>
3738
</actionGroup>
3839
<actionGroup name="fillSlideOutPanelFieldPadding">
3940
<arguments>

app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderAdvancedConfigurationTest.xml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1094,7 +1094,7 @@
10941094
<title value="Invalid - Border Width"/>
10951095
<description value="A user cannot add an invalid value for border width"/>
10961096
<severity value="MAJOR"/>
1097-
<useCaseId value="MAGETWO-83415"/>
1097+
<useCaseId value="MC-3723"/>
10981098
<testCaseId value="MC-4176"/>
10991099
<group value="pagebuilder"/>
11001100
<group value="pagebuilder-advancedConfig"/>
@@ -1384,7 +1384,7 @@
13841384
<title value="Invalid - Border Radius"/>
13851385
<description value="A user cannot add an invalid value for border radius"/>
13861386
<severity value="MAJOR"/>
1387-
<useCaseId value="MAGETWO-83415"/>
1387+
<useCaseId value="MC-3723"/>
13881388
<testCaseId value="MC-4185"/>
13891389
<group value="pagebuilder"/>
13901390
<group value="pagebuilder-advancedConfig"/>
@@ -1533,6 +1533,7 @@
15331533
</actionGroup>
15341534
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings2"/>
15351535
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusEditor3"/>
1536+
<!-- Stage: Check Border Radius: Empty -->
15361537
<comment userInput="Stage: Check Border Radius: Empty" stepKey="commentStageCheckEmpty"/>
15371538
<actionGroup ref="validateAdvancedStyleWithNoAlignmentEmptyBorderRadius" stepKey="validateStageEmpty">
15381539
<argument name="page" value="TextOnStage"/>
@@ -1545,6 +1546,7 @@
15451546
<argument name="borderRadius" value="PageBuilderAdvancedBorderRadiusProperty12"/>
15461547
<argument name="index" value="2"/>
15471548
</actionGroup>
1549+
<!-- Validate Stage After Save -->
15481550
<comment userInput="Validate Stage After Save" stepKey="commentStageAfterSave"/>
15491551
<actionGroup ref="saveAndContinueEditCmsPage" stepKey="saveAndContinueEditCmsPage"/>
15501552
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage2"/>
@@ -1746,7 +1748,7 @@
17461748
<title value="Invalid - Margins"/>
17471749
<description value="A user cannot add an invalid value for margins"/>
17481750
<severity value="MAJOR"/>
1749-
<useCaseId value="MAGETWO-83415"/>
1751+
<useCaseId value="MC-3723"/>
17501752
<testCaseId value="MC-4195"/>
17511753
<group value="pagebuilder"/>
17521754
<group value="pagebuilder-advancedConfig"/>
@@ -2161,7 +2163,7 @@
21612163
<title value="Invalid - Padding"/>
21622164
<description value="A user cannot add an invalid value for padding"/>
21632165
<severity value="MAJOR"/>
2164-
<useCaseId value="MAGETWO-83415"/>
2166+
<useCaseId value="MC-3723"/>
21652167
<testCaseId value="MC-4214"/>
21662168
<group value="pagebuilder"/>
21672169
<group value="pagebuilder-advancedConfig"/>

0 commit comments

Comments
 (0)