Skip to content

Commit e674a15

Browse files
anthoulaanthoula
committed
MC-3723: Advanced properties saving when invalid value is specified
- add test for invalid border width cases
1 parent b46e85b commit e674a15

File tree

2 files changed

+107
-1
lines changed

2 files changed

+107
-1
lines changed

‎app/code/Magento/PageBuilder/Test/Mftf/Data/AdvancedData.xml

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,11 +215,26 @@
215215
<data key="fieldName">border_width</data>
216216
<data key="value"/>
217217
</entity>
218-
<entity name="PageBuilderAdvancedBorderWidthPropertyInvalid" type="pagebuilder_advanced_border_width_property">
218+
<entity name="PageBuilderAdvancedBorderWidthProperty_NonNumeric" type="pagebuilder_advanced_border_width_property">
219219
<data key="name">Border Width</data>
220220
<data key="section">advanced</data>
221221
<data key="fieldName">border_width</data>
222222
<data key="value">garbage</data>
223+
<data key="errorMessage">Please enter a valid number in this field.</data>
224+
</entity>
225+
<entity name="PageBuilderAdvancedBorderWidthProperty_Negative" type="pagebuilder_advanced_border_width_property">
226+
<data key="name">Border Width</data>
227+
<data key="section">advanced</data>
228+
<data key="fieldName">border_width</data>
229+
<data key="value">-1</data>
230+
<data key="errorMessage">Please enter a value greater than or equal to 0.</data>
231+
</entity>
232+
<entity name="PageBuilderAdvancedBorderWidthProperty_11" type="pagebuilder_advanced_border_width_property">
233+
<data key="name">Border Width</data>
234+
<data key="section">advanced</data>
235+
<data key="fieldName">border_width</data>
236+
<data key="value">11</data>
237+
<data key="errorMessage">Please enter a value less than or equal to 10.</data>
223238
</entity>
224239
<!-- Border Radius -->
225240
<entity name="PageBuilderAdvancedBorderRadiusDefaultProperty" type="pagebuilder_advanced_border_radius_property">

‎app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderAdvancedConfigurationTest.xml

Lines changed: 91 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1080,6 +1080,97 @@
10801080
<argument name="index" value="4"/>
10811081
</actionGroup>
10821082
</test>
1083+
<test name="AdvancedConfigurationInvalidBorderWidth">
1084+
<annotations>
1085+
<features value="PageBuilder"/>
1086+
<stories value="Advanced Configuration"/>
1087+
<title value="Functional - Invalid Border Width"/>
1088+
<description value="A user cannot add an invalid value for border width"/>
1089+
<severity value="CRITICAL"/>
1090+
<useCaseId value="MAGETWO-83415"/>
1091+
<testCaseId value="MC-4176"/>
1092+
<group value="pagebuilder"/>
1093+
<group value="pagebuilder-advancedConfig"/>
1094+
</annotations>
1095+
<before>
1096+
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
1097+
<actionGroup ref="navigateToAPageWithPageBuilder" stepKey="navigateToAPageWithPageBuilder"/>
1098+
<actionGroup ref="switchToPageBuilderStage" stepKey="switchToPageBuilderStage"/>
1099+
</before>
1100+
<after>
1101+
<actionGroup ref="logout" stepKey="logout"/>
1102+
</after>
1103+
<actionGroup ref="addPageBuilderPageTitle" stepKey="enterPageTitle">
1104+
<argument name="contentType" value="PageBuilderTextContentType"/>
1105+
</actionGroup>
1106+
<actionGroup ref="expandPageBuilderPanelGroup" stepKey="expandPageBuilderPanelGroup">
1107+
<argument name="group" value="PageBuilderTextContentType"/>
1108+
</actionGroup>
1109+
<!-- Add Text to Stage -->
1110+
<comment userInput="Add Text to Stage" stepKey="commentAddTextToStage"/>
1111+
<actionGroup ref="dragContentTypeToContainer" stepKey="dragTextIntoStage">
1112+
<argument name="contentType" value="PageBuilderTextContentType"/>
1113+
<argument name="containerTargetType" value="PageBuilderRowContentType"/>
1114+
<argument name="containerTargetIndex" value="1"/>
1115+
<argument name="contentTypeIndex" value="1"/>
1116+
</actionGroup>
1117+
<!-- Add Invalid Border Width: NonNumeric -->
1118+
<comment userInput="Add Border Width: NonNumeric" stepKey="commentAddBorderWidthNonNumeric"/>
1119+
<click selector="{{PageBuilderPanel.searchPanel}}" stepKey="unFocusEditor"/>
1120+
<actionGroup ref="openPageBuilderEditPanelByIndex" stepKey="openEditMenuOnStage">
1121+
<argument name="contentType" value="PageBuilderTextContentType"/>
1122+
<argument name="contentTypeIndex" value="1"/>
1123+
</actionGroup>
1124+
<actionGroup ref="addTextToTinyMCE" stepKey="enterText">
1125+
<argument name="property" value="PageBuilderTextProperty"/>
1126+
</actionGroup>
1127+
<actionGroup ref="selectSlideOutPanelFieldGeneral" stepKey="selectBorder">
1128+
<argument name="property" value="PageBuilderAdvancedBorderPropertySolid"/>
1129+
</actionGroup>
1130+
<actionGroup ref="fillSlideOutPanelFieldAndExpectToSeeErrorInFieldset" stepKey="enterNonNumericBorderWidth">
1131+
<argument name="property" value="PageBuilderAdvancedBorderWidthProperty_NonNumeric"/>
1132+
</actionGroup>
1133+
<actionGroup ref="saveEditPanelAndValidateFieldError" stepKey="validateErrorNonNumeric">
1134+
<argument name="property" value="PageBuilderAdvancedBorderWidthProperty_NonNumeric"/>
1135+
</actionGroup>
1136+
<actionGroup ref="clearSlideOutPanelFieldGeneral" stepKey="clearBorderWidthNonNumeric">
1137+
<argument name="property" value="PageBuilderAdvancedBorderWidthPropertyDefault"/>
1138+
</actionGroup>
1139+
<!-- Add Invalid Border Width: Negative -->
1140+
<comment userInput="Add Border Width: Negative" stepKey="commentAddBorderWidthNegative"/>
1141+
<actionGroup ref="fillSlideOutPanelFieldAndExpectToSeeErrorInFieldset" stepKey="enterNegativeBorderWidth">
1142+
<argument name="property" value="PageBuilderAdvancedBorderWidthProperty_Negative"/>
1143+
</actionGroup>
1144+
<actionGroup ref="saveEditPanelAndValidateFieldError" stepKey="validateErrorNegative">
1145+
<argument name="property" value="PageBuilderAdvancedBorderWidthProperty_Negative"/>
1146+
</actionGroup>
1147+
<actionGroup ref="clearSlideOutPanelFieldGeneral" stepKey="clearBorderWidthNegative">
1148+
<argument name="property" value="PageBuilderAdvancedBorderWidthPropertyDefault"/>
1149+
</actionGroup>
1150+
<!-- Add Invalid Border Width: 11 -->
1151+
<comment userInput="Add Border Width: 11" stepKey="commentAddBorderWidth11"/>
1152+
<actionGroup ref="fillSlideOutPanelFieldAndExpectToSeeErrorInFieldset" stepKey="enter11BorderWidth">
1153+
<argument name="property" value="PageBuilderAdvancedBorderWidthProperty_11"/>
1154+
</actionGroup>
1155+
<actionGroup ref="saveEditPanelAndValidateFieldError" stepKey="validateError11">
1156+
<argument name="property" value="PageBuilderAdvancedBorderWidthProperty_11"/>
1157+
</actionGroup>
1158+
<actionGroup ref="clearSlideOutPanelFieldGeneral" stepKey="clearBorderWidth11">
1159+
<argument name="property" value="PageBuilderAdvancedBorderWidthPropertyDefault"/>
1160+
</actionGroup>
1161+
<!-- User can recover after invalid input -->
1162+
<comment userInput="User can recover after invalid input" stepKey="commentCanRecover"/>
1163+
<actionGroup ref="fillSlideOutPanelField" stepKey="enterBorderWidth2">
1164+
<argument name="property" value="PageBuilderAdvancedBorderWidthProperty10"/>
1165+
</actionGroup>
1166+
<actionGroup ref="saveEditPanelSettings" stepKey="saveEditPanelSettings"/>
1167+
<actionGroup ref="validateAdvancedStyleWithNoAlignment" stepKey="validateStage">
1168+
<argument name="page" value="TextOnStage"/>
1169+
<argument name="border" value="PageBuilderAdvancedBorderPropertySolid"/>
1170+
<argument name="borderWidth" value="PageBuilderAdvancedBorderWidthProperty10"/>
1171+
<argument name="index" value="1"/>
1172+
</actionGroup>
1173+
</test>
10831174
<test name="AdvancedConfigurationFunctionalBorderWidth">
10841175
<annotations>
10851176
<features value="PageBuilder"/>

0 commit comments

Comments
 (0)