Skip to content

Commit f35ddfe

Browse files
committed
MC-3934: Slide/Banner Overlay & Button Do Not Show On Storefront When Set To On Hover
Use getAttribute to resolve target attribute on simulated anchor (div node)
1 parent cdc79e4 commit f35ddfe

File tree

2 files changed

+2
-2
lines changed
  • app/code/Magento/PageBuilder/view/adminhtml/web

2 files changed

+2
-2
lines changed

app/code/Magento/PageBuilder/view/adminhtml/web/js/property/link.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/code/Magento/PageBuilder/view/adminhtml/web/ts/js/property/link.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ export default class Link implements PropertyReaderInterface {
3434

3535
return {
3636
[attributeLinkType]: href,
37-
setting: element.target === "_blank",
37+
setting: element.getAttribute("target") === "_blank",
3838
type: attributeLinkType,
3939
};
4040
}

0 commit comments

Comments
 (0)