Skip to content

Add missing id attribute to the Reader.php #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Add missing id attribute to the Reader.php #895

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
faf8007
Add missing id attribute to the Reader.php
FY0u11 Apr 25, 2025
6d89387
Merge branch 'develop' into fix-1
engcom-Hotel Jul 24, 2025
b81b410
Update Reader.php
engcom-Hotel Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/code/Magento/PageBuilder/Model/Config/ContentType/Reader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php
/**
* Copyright 2018 Adobe
* Copyright 2017 Adobe
* All Rights Reserved.
*/

Expand Down Expand Up @@ -31,6 +31,7 @@ class Reader extends \Magento\Framework\Config\Reader\Filesystem
self::TYPE_PATH . '/appearances/appearance/elements/element/static_style'
=> 'source',
self::TYPE_PATH . '/additional_data/item' => 'name',
self::TYPE_PATH . '/additional_data/item/item' => 'name',
self::TYPE_PATH . '/appearances/appearance/elements/element/attribute' => 'name',
self::TYPE_PATH . '/appearances/appearance/elements/element/static_attribute'
=> 'source',
Expand Down