Skip to content

Commit ae2efce

Browse files
author
Roman Glushko
committed
#184 Fixed checkstyle issues
1 parent 27aea9b commit ae2efce

File tree

1 file changed

+26
-15
lines changed

1 file changed

+26
-15
lines changed

src/com/magento/idea/magento2plugin/actions/generation/dialog/CreateAnObserverDialog.java

Lines changed: 26 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -17,19 +17,18 @@
1717
import com.magento.idea.magento2plugin.magento.packages.File;
1818
import com.magento.idea.magento2plugin.magento.packages.Package;
1919
import com.magento.idea.magento2plugin.ui.FilteredComboBox;
20-
import org.jetbrains.annotations.NotNull;
21-
20+
import java.awt.event.KeyEvent;
21+
import java.awt.event.WindowAdapter;
22+
import java.awt.event.WindowEvent;
23+
import java.util.List;
2224
import javax.swing.JButton;
2325
import javax.swing.JComboBox;
2426
import javax.swing.JComponent;
2527
import javax.swing.JLabel;
2628
import javax.swing.JPanel;
2729
import javax.swing.JTextField;
2830
import javax.swing.KeyStroke;
29-
import java.awt.event.KeyEvent;
30-
import java.awt.event.WindowAdapter;
31-
import java.awt.event.WindowEvent;
32-
import java.util.List;
31+
import org.jetbrains.annotations.NotNull;
3332

3433
public class CreateAnObserverDialog extends AbstractDialog {
3534
@NotNull
@@ -51,6 +50,12 @@ public class CreateAnObserverDialog extends AbstractDialog {
5150
private JLabel observerNameLabel;
5251
private JTextField observerName;
5352

53+
/**
54+
* Constructor.
55+
*
56+
* @param project Project Scope
57+
* @param targetEvent Action Event
58+
*/
5459
public CreateAnObserverDialog(@NotNull Project project, String targetEvent) {
5560
this.project = project;
5661
this.targetEvent = targetEvent;
@@ -79,10 +84,10 @@ public void windowClosing(WindowEvent e) {
7984
}
8085

8186
/**
82-
* Open an action dialog
87+
* Open an action dialog.
8388
*
84-
* @param project
85-
* @param targetEvent
89+
* @param project Project Scope
90+
* @param targetEvent Action Event
8691
*/
8792
public static void open(@NotNull Project project, String targetEvent) {
8893
CreateAnObserverDialog dialog = new CreateAnObserverDialog(project, targetEvent);
@@ -92,7 +97,7 @@ public static void open(@NotNull Project project, String targetEvent) {
9297
}
9398

9499
/**
95-
* Setup observer area combobox
100+
* Setup observer area combobox.
96101
*/
97102
private void fillTargetAreaOptions() {
98103
for (Package.Areas area : Package.Areas.values()) {
@@ -101,7 +106,7 @@ private void fillTargetAreaOptions() {
101106
}
102107

103108
/**
104-
* Perform code generation using input data
109+
* Perform code generation using input data.
105110
*/
106111
private void onOK() {
107112
if (!validator.validate(project)) {
@@ -147,18 +152,24 @@ public String getObserverModule() {
147152
return this.observerModule.getSelectedItem().toString();
148153
}
149154

150-
@SuppressWarnings("checkstyle:AbbreviationAsWordInName")
151-
private void createUIComponents() {
155+
private void createUiComponents() {
152156
List<String> allModulesList = ModuleIndex.getInstance(project).getEditableModuleNames();
153157

154158
this.observerModule = new FilteredComboBox(allModulesList);
155159
}
156160

157161
private String getNamespace() {
158162
String targetModule = getObserverModule();
159-
String namespace = targetModule.replace(Package.VENDOR_MODULE_NAME_SEPARATOR, Package.FQN_SEPARATOR);
163+
String namespace = targetModule.replace(
164+
Package.VENDOR_MODULE_NAME_SEPARATOR,
165+
Package.FQN_SEPARATOR
166+
);
167+
160168
namespace = namespace.concat(Package.FQN_SEPARATOR);
161-
return namespace.concat(getObserverDirectory().replace(File.separator, Package.FQN_SEPARATOR));
169+
return namespace.concat(getObserverDirectory().replace(
170+
File.separator,
171+
Package.FQN_SEPARATOR)
172+
);
162173
}
163174

164175
private String getObserverClassFqn() {

0 commit comments

Comments
 (0)