magento2-login-as-customer/issues/90: Tests stabilization

Author: naydav

app/code/Magento/LoginAsCustomerWebapi/Api/LoginAsCustomerWebapiCreateCustomerAccessTokenInterface.php renamed to app/code/Magento/LoginAsCustomerWebapi/Api/CreateCustomerAccessTokenInterface.php

@@ -7,15 +7,12 @@
 
 namespace Magento\LoginAsCustomerWebapi\Api;
 
-use Magento\Framework\Exception\LocalizedException;
-use Magento\Framework\Exception\NoSuchEntityException;
-
 /**
  * Interface providing customer token generation for admin.
  *
  * @api
  */
-interface LoginAsCustomerWebapiCreateCustomerAccessTokenInterface
+interface CreateCustomerAccessTokenInterface
 {
     /**
      * Create access token for admin by customer id.

app/code/Magento/LoginAsCustomerWebapi/Model/LoginAsCustomerWebapiCreateCustomerAccessToken.php renamed to app/code/Magento/LoginAsCustomerWebapi/Model/CreateCustomerAccessToken.php

@@ -12,12 +12,12 @@
 use Magento\Framework\Exception\LocalizedException;
 use Magento\Integration\Model\Oauth\TokenFactory;
 use Magento\LoginAsCustomerApi\Api\ConfigInterface;
-use Magento\LoginAsCustomerWebapi\Api\LoginAsCustomerWebapiCreateCustomerAccessTokenInterface;
+use Magento\LoginAsCustomerWebapi\Api\CreateCustomerAccessTokenInterface;
 
 /**
  * @inheritdoc
  */
-class LoginAsCustomerWebapiCreateCustomerAccessToken implements LoginAsCustomerWebapiCreateCustomerAccessTokenInterface
+class CreateCustomerAccessToken implements CreateCustomerAccessTokenInterface
 {
     /**
      * @var ConfigInterface

app/code/Magento/LoginAsCustomerWebapi/etc/acl.xml

@@ -11,7 +11,7 @@
             <resource id="Magento_Backend::admin">
                 <resource id="Magento_Customer::customer">
                     <resource id="Magento_LoginAsCustomer::login" title="Login as Customer" sortOrder="50">
-                        <resource id="Magento_LoginAsCustomer::login_token" title="Create Login as Customer Token" sortOrder="30" />
+                        <resource id="Magento_LoginAsCustomerWebapi::login_token" title="Create Login as Customer Token" sortOrder="30" />
                     </resource>
                 </resource>
             </resource>

app/code/Magento/LoginAsCustomerWebapi/etc/webapi.xml

@@ -8,9 +8,9 @@
 <routes xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Webapi:etc/webapi.xsd">
     <route url="/V1/login-as-customer/token" method="POST">
-        <service class="\Magento\LoginAsCustomerWebapi\Api\LoginAsCustomerWebapiCreateCustomerAccessTokenInterface" method="execute"/>
+        <service class="\Magento\LoginAsCustomerWebapi\Api\CreateCustomerAccessTokenInterface" method="execute"/>
         <resources>
-            <resource ref="Magento_LoginAsCustomer::login_token"/>
+            <resource ref="Magento_LoginAsCustomerWebapi::login_token"/>
         </resources>
     </route>
 </routes>

app/code/Magento/LoginAsCustomerWebapi/etc/webapi_rest/di.xml

@@ -7,6 +7,6 @@
 -->
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
-    <preference for="Magento\LoginAsCustomerWebapi\Api\LoginAsCustomerWebapiCreateCustomerAccessTokenInterface"
-                type="Magento\LoginAsCustomerWebapi\Model\LoginAsCustomerWebapiCreateCustomerAccessToken"/>
+    <preference for="Magento\LoginAsCustomerWebapi\Api\CreateCustomerAccessTokenInterface"
+                type="Magento\LoginAsCustomerWebapi\Model\CreateCustomerAccessToken"/>
 </config>

dev/tests/api-functional/testsuite/Magento/LoginAsCustomerWebapi/Api/LoginAsCustomerWebapiCreateCustomerAccessTokenTest.php

@@ -3,6 +3,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
 namespace Magento\LoginAsCustomerWebapi\Api;
 
@@ -42,9 +43,9 @@ public function setUp()
      */
     public function testCreateCustomerAccessToken()
     {
-        // 'Magento_LoginAsCustomer::login_token' resource required for access.
+        // 'Magento_LoginAsCustomerWebapi::login_token' resource required for access.
         OauthHelper::clearApiAccessCredentials();
-        OauthHelper::getApiAccessCredentials(['Magento_LoginAsCustomer::login_token']);
+        OauthHelper::getApiAccessCredentials(['Magento_LoginAsCustomerWebapi::login_token']);
         try {
             $customerId = 1;
 
@@ -96,7 +97,7 @@ public function testCreateCustomerAccessTokenLoginNoAccess()
         $this->expectException(\Exception::class);
         $this->expectExceptionMessage('The consumer isn\'t authorized to access %resources.');
 
-        // 'Magento_LoginAsCustomer::login_token' resource required for access.
+        // 'Magento_LoginAsCustomerWebapi::login_token' resource required for access.
         OauthHelper::clearApiAccessCredentials();
         OauthHelper::getApiAccessCredentials([]);
         try {