#16445 - getRegionHtmlSelect does not have configuration - added typehints for method arguments and return typehint

nikunjskd20 · nikunjskd20 · commit 1bfad970a870 · 2019-05-21T16:05:38.000+05:30
diff --git a/app/code/Magento/Directory/Block/Data.php b/app/code/Magento/Directory/Block/Data.php
@@ -191,7 +191,7 @@ public function getRegionHtmlSelect(): string
      * @param string $title
      * @return string
      */
-    public function getRegionSelect(string $value = null, string $name = 'region', string $id = 'state', string $title = 'State/Province'): string
+    public function getRegionSelect(int $value = null, string $name = 'region', string $id = 'state', string $title = 'State/Province'): string
     {
         \Magento\Framework\Profiler::start('TEST: ' . __METHOD__, ['group' => 'TEST', 'method' => __METHOD__]);
         if ($value === null) {

Original file line number	Diff line number	Diff line change
`@@ -191,7 +191,7 @@ public function getRegionHtmlSelect(): string`
`191`	`191`	`* @param string $title`
`192`	`192`	`* @return string`
`193`	`193`	`*/`
`194`		`- public function getRegionSelect(string $value = null, string $name = 'region', string $id = 'state', string $title = 'State/Province'): string`
	`194`	`+ public function getRegionSelect(int $value = null, string $name = 'region', string $id = 'state', string $title = 'State/Province'): string`
`195`	`195`	`{`
`196`	`196`	`\Magento\Framework\Profiler::start('TEST: ' . __METHOD__, ['group' => 'TEST', 'method' => __METHOD__]);`
`197`	`197`	`if ($value === null) {`