AC-1271: Add rate limiting for payment information endpoint and mutation

Author: arhiopterecs

app/code/Magento/Quote/Test/Unit/Model/Backpressure/OrderLimitConfigManagerTest.php

@@ -8,8 +8,6 @@
 
 namespace Magento\Quote\Test\Unit\Model\Backpressure;
 
-use Magento\Framework\App\DeploymentConfig;
-use Magento\Framework\Exception\FileSystemException;
 use Magento\Framework\Exception\RuntimeException;
 use Magento\Quote\Model\Backpressure\OrderLimitConfigManager;
 use Magento\Framework\App\Backpressure\ContextInterface;
@@ -24,11 +22,6 @@ class OrderLimitConfigManagerTest extends TestCase
      */
     private $scopeConfigMock;
 
-    /**
-     * @var DeploymentConfig|MockObject
-     */
-    private $deploymentConfigMock;
-
     /**
      * @var OrderLimitConfigManager
      */
@@ -42,12 +35,8 @@ protected function setUp(): void
         parent::setUp();
 
         $this->scopeConfigMock = $this->createMock(ScopeConfigInterface::class);
-        $this->deploymentConfigMock = $this->createMock(DeploymentConfig::class);
 
-        $this->model = new OrderLimitConfigManager(
-            $this->scopeConfigMock,
-            $this->deploymentConfigMock
-        );
+        $this->model = new OrderLimitConfigManager($this->scopeConfigMock);
     }
 
     /**
@@ -106,20 +95,13 @@ public function testReadLimit(
      *
      * @param bool $enabled
      * @param bool $expected
-     * @param string|null $requestLoggerType
      * @return void
-     * @throws RuntimeException
-     * @throws FileSystemException
      * @dataProvider getEnabledCases
      */
     public function testIsEnforcementEnabled(
         bool    $enabled,
-        bool    $expected,
-        ?string $requestLoggerType
+        bool    $expected
     ): void {
-        $this->deploymentConfigMock->method('get')
-            ->with('backpressure/logger/type')
-            ->willReturn($requestLoggerType);
         $this->scopeConfigMock->method('isSetFlag')
             ->with('sales/backpressure/enabled')
             ->willReturn($enabled);
@@ -135,10 +117,8 @@ public function testIsEnforcementEnabled(
     public function getEnabledCases(): array
     {
         return [
-            'disabled' => [false, false, null],
-            'disabled-request-logger-type-exists' => [false, false, 'requestLoggerType'],
-            'enabled-request-logger-type-not-exist' => [true, false, null],
-            'enabled' => [true, true, 'requestLoggerType'],
+            'disabled' => [false, false],
+            'enabled' => [true, true],
         ];
     }
 }

dev/tests/integration/etc/install-config-mysql.php.dist

@@ -24,4 +24,6 @@ return [
     'amqp-user' => 'guest',
     'amqp-password' => 'guest',
     'consumers-wait-for-messages' => '0',
+    'backpressure-logger' => 'redis',
+    'backpressure-logger-redis-timeout'=>10,
 ];

lib/internal/Magento/Framework/App/Backpressure/SlidingWindow/RedisRequestLogger/RedisClient.php

@@ -68,7 +68,7 @@ class RedisClient
     /**
      * @var Credis_Client
      */
-    private Credis_Client $pipeline;
+    private $pipeline;
 
     /**
      * @param DeploymentConfig $config
@@ -95,40 +95,35 @@ public function __construct(DeploymentConfig $config)
      *
      * @param string $key
      * @param int $decrement
-     * @return $this
+     * @return Credis_Client|int
      */
-    public function incrBy(string $key, int $decrement): RedisClient
+    public function incrBy(string $key, int $decrement)
     {
-        $this->pipeline->incrBy($key, $decrement);
+        return $this->pipeline->incrBy($key, $decrement);
 
-        return $this;
     }
 
     /**
      * Sets expiration date of the key
      *
      * @param string $key
      * @param int $timestamp
-     * @return $this
+     * @return Credis_Client|int
      */
-    public function expireAt(string $key, int $timestamp): RedisClient
+    public function expireAt(string $key, int $timestamp)
     {
-        $this->pipeline->expireAt($key, $timestamp);
-
-        return $this;
+        return $this->pipeline->expireAt($key, $timestamp);
     }
 
     /**
      * Returns value by key
      *
      * @param string $key
-     * @return bool|RedisClient|string
+     * @return bool|Credis_Client|string
      */
     public function get(string $key)
     {
-        $value = $this->pipeline->get($key);
-
-        return $value instanceof Credis_Client ? $this : $value;
+        return $this->pipeline->get($key);
     }
 
     /**

setup/src/Magento/Setup/Test/Unit/Model/ConfigOptionsList/BackpressureLoggerTest.php

@@ -97,6 +97,10 @@ public function testCreateConfigCacheRedis(
         $this->assertEquals($expectedConfigData, $configData->getData());
     }
 
+    /**
+     * @return array[]
+     * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+     */
     public function dataProviderCreateConfigCacheRedis(): array
     {
         return [