Merge branch 'MC-40053' into 2.4-develop-sidecar-pr12

Author: ysapiga

dev/tests/api-functional/testsuite/Magento/Swatches/Api/ProductAttributeOptionManagementInterfaceTest.php

@@ -12,6 +12,7 @@
 use Magento\Eav\Api\Data\AttributeOptionInterface;
 use Magento\Eav\Api\Data\AttributeOptionLabelInterface;
 use Magento\Eav\Model\AttributeRepository;
+use Magento\Framework\DataObject;
 use Magento\Framework\Webapi\Rest\Request;
 use Magento\Swatches\Model\ResourceModel\Swatch\Collection;
 use Magento\Swatches\Model\ResourceModel\Swatch\CollectionFactory;
@@ -25,29 +26,31 @@
 class ProductAttributeOptionManagementInterfaceTest extends WebapiAbstract
 {
     private const ATTRIBUTE_CODE = 'select_attribute';
+    private const SERVICE_NAME_UPDATE = 'catalogProductAttributeOptionUpdateV1';
     private const SERVICE_NAME = 'catalogProductAttributeOptionManagementV1';
     private const SERVICE_VERSION = 'V1';
     private const RESOURCE_PATH = '/V1/products/attributes';
 
     /**
      * Test add option to swatch attribute
      *
+     * @dataProvider addDataProvider
      * @magentoApiDataFixture Magento/Catalog/Model/Product/Attribute/_files/select_attribute.php
      * @param array $data
      * @param array $payload
      * @param int $expectedSwatchType
      * @param string $expectedLabel
      * @param string $expectedValue
      *
-     * @dataProvider addDataProvider
+     * @return void
      */
     public function testAdd(
         array $data,
         array $payload,
         int $expectedSwatchType,
         string $expectedLabel,
         string $expectedValue
-    ) {
+    ): void {
         $objectManager = Bootstrap::getObjectManager();
         /** @var $attributeRepository AttributeRepository */
         $attributeRepository = $objectManager->get(AttributeRepository::class);
@@ -74,7 +77,7 @@ public function testAdd(
         );
 
         $this->assertNotNull($response);
-        $optionId = (int) ltrim($response, 'id_');
+        $optionId = (int)ltrim($response, 'id_');
         $swatch = $this->getSwatch($optionId);
         $this->assertEquals($expectedValue, $swatch->getValue());
         $this->assertEquals($expectedSwatchType, $swatch->getType());
@@ -83,11 +86,47 @@ public function testAdd(
         $this->assertEquals($expectedLabel, $options[2]->getLabel());
     }
 
+    /**
+     * @magentoApiDataFixture Magento/Swatches/_files/text_swatch_attribute.php
+     * @return void
+     */
+    public function testUpdate(): void
+    {
+        $testAttributeCode = 'test_configurable';
+        $optionData = [
+            AttributeOptionInterface::LABEL => 'Fixture Option Changed',
+            AttributeOptionInterface::VALUE => 'option_value',
+        ];
+
+        $existOptionLabel = 'option 1';
+        $existAttributeOption = $this->getAttributeOption($testAttributeCode, $existOptionLabel);
+        $optionId = $existAttributeOption['value'];
+
+        $response = $this->webApiCallAttributeOptions(
+            $testAttributeCode,
+            Request::HTTP_METHOD_PUT,
+            'update',
+            [
+                'attributeCode' => $testAttributeCode,
+                'optionId' => $optionId,
+                'option' => $optionData,
+            ],
+            $optionId
+        );
+        $this->assertTrue($response);
+        $this->assertNotNull(
+            $this->getAttributeOption(
+                $testAttributeCode,
+                $optionData[AttributeOptionInterface::LABEL]
+            )
+        );
+    }
+
     /**
      * @return array
      * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
      */
-    public function addDataProvider()
+    public function addDataProvider(): array
     {
         return [
             'visual swatch option with value' => [
@@ -212,14 +251,99 @@ public function addDataProvider()
      * Get swatch model
      *
      * @param int $optionId
-     * @return Swatch
+     * @return DataObject
      */
-    private function getSwatch(int $optionId)
+    private function getSwatch(int $optionId): DataObject
     {
         /** @var Collection $collection */
         $collection = Bootstrap::getObjectManager()->get(CollectionFactory::class)->create();
         $collection->addFieldToFilter('option_id', $optionId);
         $collection->setPageSize(1);
+
         return $collection->getFirstItem();
     }
+
+    /**
+     * Perform Web API call to the system under test
+     *
+     * @param string $attributeCode
+     * @param string $httpMethod
+     * @param string $soapMethod
+     * @param array $arguments
+     * @param null $storeCode
+     * @param null $optionId
+     * @return array|bool|float|int|string
+     */
+    private function webApiCallAttributeOptions(
+        string $attributeCode,
+        string $httpMethod,
+        string $soapMethod,
+        array $arguments = [],
+        $optionId = null,
+        $storeCode = null
+    ) {
+        $resourcePath = self::RESOURCE_PATH . "/{$attributeCode}/options";
+        if ($optionId) {
+            $resourcePath .= '/' . $optionId;
+        }
+        $serviceName = $soapMethod === 'update' ? self::SERVICE_NAME_UPDATE : self::SERVICE_NAME;
+        $serviceInfo = [
+            'rest' => [
+                'resourcePath' => $resourcePath,
+                'httpMethod' => $httpMethod,
+            ],
+            'soap' => [
+                'service' => $serviceName,
+                'serviceVersion' => self::SERVICE_VERSION,
+                'operation' => $serviceName . $soapMethod,
+            ],
+        ];
+
+        return $this->_webApiCall($serviceInfo, $arguments, null, $storeCode);
+    }
+
+    /**
+     * Get Attribute options by attribute code
+     *
+     * @param string $testAttributeCode
+     * @param string|null $storeCode
+     * @return array|bool|float|int|string
+     */
+    private function getAttributeOptions(string $testAttributeCode, ?string $storeCode = null)
+    {
+        return $this->webApiCallAttributeOptions(
+            $testAttributeCode,
+            Request::HTTP_METHOD_GET,
+            'getItems',
+            ['attributeCode' => $testAttributeCode],
+            null,
+            $storeCode
+        );
+    }
+
+    /**
+     * Get Attribute option by attribute code
+     *
+     * @param string $attributeCode
+     * @param string $optionLabel
+     * @param string|null $storeCode
+     * @return array|null
+     */
+    private function getAttributeOption(
+        string $attributeCode,
+        string $optionLabel,
+        ?string $storeCode = null
+    ): ?array {
+        $attributeOptions = $this->getAttributeOptions($attributeCode, $storeCode);
+        $option = null;
+        /** @var array $attributeOption */
+        foreach ($attributeOptions as $attributeOption) {
+            if ($attributeOption['label'] === $optionLabel) {
+                $option = $attributeOption;
+                break;
+            }
+        }
+
+        return $option;
+    }
 }