MAGETWO-63910: Create infrastructure for mapper in Payment module

 - Refactored code
 - Added unit tests

Author: YevSent

app/code/Magento/Braintree/Model/AvsEmsCodeMapper.php

@@ -48,12 +48,14 @@ class AvsEmsCodeMapper implements PaymentVerificationInterface
      *
      * @param OrderPaymentInterface $orderPayment
      * @return string
-     * @throws \Exception
+     * @throws \InvalidArgumentException
      */
     public function getCode(OrderPaymentInterface $orderPayment)
     {
         if ($orderPayment->getMethod() !== ConfigProvider::CODE) {
-            throw new \Exception('"' . $orderPayment->getMethod() . '" does not supported by Braintree AVS mapper.');
+            throw new \InvalidArgumentException(
+                'The "' . $orderPayment->getMethod() . '" does not supported by Braintree AVS mapper.'
+            );
         }
 
         $additionalInfo = $orderPayment->getAdditionalInformation();

app/code/Magento/Braintree/Model/CvvEmsCodeMapper.php

@@ -52,7 +52,9 @@ class CvvEmsCodeMapper implements PaymentVerificationInterface
     public function getCode(OrderPaymentInterface $orderPayment)
     {
         if ($orderPayment->getMethod() !== ConfigProvider::CODE) {
-            throw new \Exception('"' . $orderPayment->getMethod() . '" does not supported by Braintree CVV mapper.');
+            throw new \InvalidArgumentException(
+                'The "' . $orderPayment->getMethod() . '" does not supported by Braintree CVV mapper.'
+            );
         }
 
         $additionalInfo = $orderPayment->getAdditionalInformation();

app/code/Magento/Braintree/Test/Unit/Model/AvsEmsCodeMapperTest.php

@@ -59,8 +59,8 @@ public function testGetCode($avsZip, $avsStreet, $expected)
      * Checks a test case, when payment order is not Braintree payment method.
      *
      * @covers \Magento\Braintree\Model\AvsEmsCodeMapper::getCode
-     * @expectedException \Exception
-     * @expectedExceptionMessage "some_payment" does not supported by Braintree AVS mapper.
+     * @expectedException \InvalidArgumentException
+     * @expectedExceptionMessage The "some_payment" does not supported by Braintree AVS mapper.
      */
     public function testGetCodeWithException()
     {

app/code/Magento/Braintree/Test/Unit/Model/CvvEmsCodeMapperTest.php

@@ -55,8 +55,8 @@ public function testGetCode($cvvCode, $expected)
      * Checks a test case, when payment order is not Braintree payment method.
      *
      * @covers \Magento\Braintree\Model\CvvEmsCodeMapper::getCode
-     * @expectedException \Exception
-     * @expectedExceptionMessage "some_payment" does not supported by Braintree CVV mapper.
+     * @expectedException \InvalidArgumentException
+     * @expectedExceptionMessage The "some_payment" does not supported by Braintree CVV mapper.
      */
     public function testGetCodeWithException()
     {

app/code/Magento/Payment/Api/PaymentVerificationInterface.php

@@ -24,9 +24,11 @@ interface PaymentVerificationInterface
 {
     /**
      * Gets payment provider verification code.
+     * Throws an exception if provided payment method is different to verification implementation.
      *
      * @param OrderPaymentInterface $orderPayment
      * @return string
+     * @throws \InvalidArgumentException
      */
     public function getCode(OrderPaymentInterface $orderPayment);
 }