#27500 Migrate PHPUnit tests for module

Author: lbajsarowicz

setup/src/Magento/Setup/Test/Unit/Console/Command/AdminUserCreateCommandTest.php

@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 /**
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
@@ -7,36 +7,41 @@
 
 use Magento\Setup\Console\Command\AdminUserCreateCommand;
 use Magento\Setup\Model\AdminAccount;
+use Magento\Setup\Model\Installer;
+use Magento\Setup\Model\InstallerFactory;
 use Magento\Setup\Mvc\Bootstrap\InitParamListener;
 use Magento\User\Model\UserValidationRules;
+use PHPUnit\Framework\MockObject\MockObject;
+use PHPUnit\Framework\TestCase;
 use Symfony\Component\Console\Application;
 use Symfony\Component\Console\Helper\QuestionHelper;
+use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Tester\CommandTester;
 
 /**
  * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
-class AdminUserCreateCommandTest extends \PHPUnit\Framework\TestCase
+class AdminUserCreateCommandTest extends TestCase
 {
     /**
-     * @var \PHPUnit_Framework_MockObject_MockObject|\Symfony\Component\Console\Helper\QuestionHelper
+     * @var MockObject|QuestionHelper
      */
     private $questionHelperMock;
 
     /**
-     * @var \PHPUnit_Framework_MockObject_MockObject|\Magento\Setup\Model\InstallerFactory
+     * @var MockObject|InstallerFactory
      */
     private $installerFactoryMock;
 
     /**
-     * @var \PHPUnit_Framework_MockObject_MockObject|AdminUserCreateCommand
+     * @var MockObject|AdminUserCreateCommand
      */
     private $command;
 
-    public function setUp()
+    public function setUp(): void
     {
-        $this->installerFactoryMock = $this->createMock(\Magento\Setup\Model\InstallerFactory::class);
+        $this->installerFactoryMock = $this->createMock(InstallerFactory::class);
         $this->command = new AdminUserCreateCommand($this->installerFactoryMock, new UserValidationRules());
 
         $this->questionHelperMock = $this->getMockBuilder(QuestionHelper::class)
@@ -62,7 +67,7 @@ public function testExecute()
             InitParamListener::BOOTSTRAP_PARAM => null,
         ];
         $commandTester = new CommandTester($this->command);
-        $installerMock = $this->createMock(\Magento\Setup\Model\Installer::class);
+        $installerMock = $this->createMock(Installer::class);
         $installerMock->expects($this->once())->method('installAdminUser')->with($data);
         $this->installerFactoryMock->expects($this->once())->method('create')->willReturn($installerMock);
         $commandTester->execute($options, ['interactive' => false]);
@@ -97,7 +102,7 @@ public function testInteraction()
         // We override the standard helper with our mock
         $this->command->getHelperSet()->set($this->questionHelperMock, 'question');
 
-        $installerMock = $this->createMock(\Magento\Setup\Model\Installer::class);
+        $installerMock = $this->createMock(Installer::class);
 
         $expectedData = [
             'admin-user' => 'admin',
@@ -167,7 +172,7 @@ public function getOptionListDataProvider()
     public function testValidate(array $options, array $errors)
     {
         $inputMock = $this->getMockForAbstractClass(
-            \Symfony\Component\Console\Input\InputInterface::class,
+            InputInterface::class,
             [],
             '',
             false

setup/src/Magento/Setup/Test/Unit/Console/Command/BackupCommandTest.php

@@ -1,23 +1,33 @@
-<?php
+<?php declare(strict_types=1);
 /**
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
 namespace Magento\Setup\Test\Unit\Console\Command;
 
 use Magento\Framework\App\Console\MaintenanceModeEnabler;
+use Magento\Framework\App\DeploymentConfig;
+use Magento\Framework\App\MaintenanceMode;
+use Magento\Framework\App\State;
+use Magento\Framework\ObjectManager\ConfigLoaderInterface;
+use Magento\Framework\ObjectManagerInterface;
+use Magento\Framework\Setup\BackupRollback;
+use Magento\Framework\Setup\BackupRollbackFactory;
 use Magento\Setup\Console\Command\BackupCommand;
+use Magento\Setup\Model\ObjectManagerProvider;
+use PHPUnit\Framework\MockObject\MockObject;
+use PHPUnit\Framework\TestCase;
 use Symfony\Component\Console\Tester\CommandTester;
 
-class BackupCommandTest extends \PHPUnit\Framework\TestCase
+class BackupCommandTest extends TestCase
 {
     /**
-     * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
+     * @var ObjectManagerInterface|MockObject
      */
     private $objectManager;
 
     /**
-     * @var \Magento\Framework\Setup\BackupRollback|\PHPUnit_Framework_MockObject_MockObject
+     * @var BackupRollback|MockObject
      */
     private $backupRollback;
 
@@ -27,35 +37,35 @@ class BackupCommandTest extends \PHPUnit\Framework\TestCase
     private $tester;
 
     /**
-     * @var \Magento\Framework\Setup\BackupRollbackFactory|\PHPUnit_Framework_MockObject_MockObject
+     * @var BackupRollbackFactory|MockObject
      */
     private $backupRollbackFactory;
 
     /**
-     * @var \Magento\Framework\App\DeploymentConfig|\PHPUnit_Framework_MockObject_MockObject
+     * @var DeploymentConfig|MockObject
      */
     private $deploymentConfig;
 
-    public function setUp()
+    public function setUp(): void
     {
-        $maintenanceMode = $this->createMock(\Magento\Framework\App\MaintenanceMode::class);
-        $objectManagerProvider = $this->createMock(\Magento\Setup\Model\ObjectManagerProvider::class);
+        $maintenanceMode = $this->createMock(MaintenanceMode::class);
+        $objectManagerProvider = $this->createMock(ObjectManagerProvider::class);
         $this->objectManager = $this->getMockForAbstractClass(
-            \Magento\Framework\ObjectManagerInterface::class,
+            ObjectManagerInterface::class,
             [],
             '',
             false
         );
         $objectManagerProvider->expects($this->any())->method('get')->willReturn($this->objectManager);
-        $this->backupRollback = $this->createMock(\Magento\Framework\Setup\BackupRollback::class);
-        $this->backupRollbackFactory = $this->createMock(\Magento\Framework\Setup\BackupRollbackFactory::class);
+        $this->backupRollback = $this->createMock(BackupRollback::class);
+        $this->backupRollbackFactory = $this->createMock(BackupRollbackFactory::class);
         $this->backupRollbackFactory->expects($this->any())
             ->method('create')
             ->willReturn($this->backupRollback);
-        $this->deploymentConfig = $this->createMock(\Magento\Framework\App\DeploymentConfig::class);
-        $appState = $this->createMock(\Magento\Framework\App\State::class);
+        $this->deploymentConfig = $this->createMock(DeploymentConfig::class);
+        $appState = $this->createMock(State::class);
         $configLoader = $this->getMockForAbstractClass(
-            \Magento\Framework\ObjectManager\ConfigLoaderInterface::class,
+            ConfigLoaderInterface::class,
             [],
             '',
             false
@@ -66,9 +76,9 @@ public function setUp()
             ->method('get')
             ->will(
                 $this->returnValueMap([
-                    [\Magento\Framework\Setup\BackupRollbackFactory::class, $this->backupRollbackFactory],
-                    [\Magento\Framework\App\State::class, $appState],
-                    [\Magento\Framework\ObjectManager\ConfigLoaderInterface::class, $configLoader],
+                    [BackupRollbackFactory::class, $this->backupRollbackFactory],
+                    [State::class, $appState],
+                    [ConfigLoaderInterface::class, $configLoader],
                 ])
             );
         $command = new BackupCommand(

setup/src/Magento/Setup/Test/Unit/Console/Command/ConfigSetCommandTest.php

@@ -1,46 +1,53 @@
-<?php
+<?php declare(strict_types=1);
 /**
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
 
 namespace Magento\Setup\Test\Unit\Console\Command;
 
+use Magento\Framework\App\DeploymentConfig;
 use Magento\Framework\Module\ModuleList;
+use Magento\Framework\Setup\Option\TextConfigOption;
 use Magento\Setup\Console\Command\ConfigSetCommand;
+use Magento\Setup\Model\ConfigModel;
+use PHPUnit\Framework\MockObject\MockObject;
+use PHPUnit\Framework\TestCase;
+use Symfony\Component\Console\Helper\HelperSet;
+use Symfony\Component\Console\Helper\QuestionHelper;
 use Symfony\Component\Console\Tester\CommandTester;
 
-class ConfigSetCommandTest extends \PHPUnit\Framework\TestCase
+class ConfigSetCommandTest extends TestCase
 {
     /**
-     * @var \PHPUnit_Framework_MockObject_MockObject|\Magento\Setup\Model\ConfigModel
+     * @var MockObject|ConfigModel
      */
     private $configModel;
 
     /**
-     * @var \PHPUnit_Framework_MockObject_MockObject|\Magento\Framework\App\DeploymentConfig
+     * @var MockObject|DeploymentConfig
      */
     private $deploymentConfig;
 
     /**
-     * @var \PHPUnit_Framework_MockObject_MockObject|\Magento\Setup\Console\Command\ConfigSetCommand
+     * @var MockObject|ConfigSetCommand
      */
     private $command;
 
-    public function setUp()
+    public function setUp(): void
     {
-        $option = $this->createMock(\Magento\Framework\Setup\Option\TextConfigOption::class);
+        $option = $this->createMock(TextConfigOption::class);
         $option
             ->expects($this->any())
             ->method('getName')
             ->will($this->returnValue('db-host'));
-        $this->configModel = $this->createMock(\Magento\Setup\Model\ConfigModel::class);
+        $this->configModel = $this->createMock(ConfigModel::class);
         $this->configModel
             ->expects($this->exactly(2))
             ->method('getAvailableOptions')
             ->will($this->returnValue([$option]));
-        $moduleList = $this->createMock(\Magento\Framework\Module\ModuleList::class);
-        $this->deploymentConfig = $this->createMock(\Magento\Framework\App\DeploymentConfig::class);
+        $moduleList = $this->createMock(ModuleList::class);
+        $this->deploymentConfig = $this->createMock(DeploymentConfig::class);
         $this->command = new ConfigSetCommand($this->configModel, $moduleList, $this->deploymentConfig);
     }
 
@@ -96,14 +103,14 @@ public function testExecuteInteractiveWithNo()
      */
     private function checkInteraction($interactionType)
     {
-        $dialog = $this->createMock(\Symfony\Component\Console\Helper\QuestionHelper::class);
+        $dialog = $this->createMock(QuestionHelper::class);
         $dialog
             ->expects($this->once())
             ->method('ask')
             ->will($this->returnValue($interactionType));
 
-        /** @var \Symfony\Component\Console\Helper\HelperSet|\PHPUnit_Framework_MockObject_MockObject $helperSet */
-        $helperSet = $this->createMock(\Symfony\Component\Console\Helper\HelperSet::class);
+        /** @var HelperSet|MockObject $helperSet */
+        $helperSet = $this->createMock(HelperSet::class);
         $helperSet
             ->expects($this->once())
             ->method('get')
@@ -116,7 +123,7 @@ private function checkInteraction($interactionType)
         if (strtolower($interactionType) === 'y') {
             $message = 'You saved the new configuration.' . PHP_EOL;
         } else {
-            $message = 'You made no changes to the configuration.'.PHP_EOL;
+            $message = 'You made no changes to the configuration.' . PHP_EOL;
         }
         $this->assertSame(
             $message,

setup/src/Magento/Setup/Test/Unit/Console/Command/CronRunCommandTest.php

@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types=1);
 /**
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
@@ -7,12 +7,18 @@
 
 use Magento\Framework\App\DeploymentConfig;
 use Magento\Setup\Console\Command\CronRunCommand;
+use Magento\Setup\Model\Cron\AbstractJob;
+use Magento\Setup\Model\Cron\Queue;
+use Magento\Setup\Model\Cron\ReadinessCheck;
+use Magento\Setup\Model\Cron\Status;
+use PHPUnit\Framework\MockObject\MockObject;
+use PHPUnit\Framework\TestCase;
 use Symfony\Component\Console\Tester\CommandTester;
 
-class CronRunCommandTest extends \PHPUnit\Framework\TestCase
+class CronRunCommandTest extends TestCase
 {
     /**
-     * @var \PHPUnit_Framework_MockObject_MockObject|DeploymentConfig
+     * @var MockObject|DeploymentConfig
      */
     private $deploymentConfig;
 
@@ -27,26 +33,26 @@ class CronRunCommandTest extends \PHPUnit\Framework\TestCase
     private $commandTester;
 
     /**
-     * @var \PHPUnit_Framework_MockObject_MockObject|\Magento\Setup\Model\Cron\Queue
+     * @var MockObject|Queue
      */
     private $queue;
 
     /**
-     * @var \PHPUnit_Framework_MockObject_MockObject|\Magento\Setup\Model\Cron\ReadinessCheck
+     * @var MockObject|ReadinessCheck
      */
     private $readinessCheck;
 
     /**
-     * @var \PHPUnit_Framework_MockObject_MockObject|\Magento\Setup\Model\Cron\Status
+     * @var MockObject|Status
      */
     private $status;
 
-    public function setUp()
+    public function setUp(): void
     {
-        $this->deploymentConfig = $this->createMock(\Magento\Framework\App\DeploymentConfig::class);
-        $this->queue = $this->createMock(\Magento\Setup\Model\Cron\Queue::class);
-        $this->readinessCheck = $this->createMock(\Magento\Setup\Model\Cron\ReadinessCheck::class);
-        $this->status = $this->createMock(\Magento\Setup\Model\Cron\Status::class);
+        $this->deploymentConfig = $this->createMock(DeploymentConfig::class);
+        $this->queue = $this->createMock(Queue::class);
+        $this->readinessCheck = $this->createMock(ReadinessCheck::class);
+        $this->status = $this->createMock(Status::class);
         $this->command = new CronRunCommand(
             $this->deploymentConfig,
             $this->queue,
@@ -150,7 +156,7 @@ public function testExecuteJobFailed()
         $this->setUpPreliminarySuccess();
         $this->queue->expects($this->at(0))->method('peek')->willReturn(['name' => 'setup:']);
         $this->queue->expects($this->at(1))->method('peek')->willReturn(['name' => 'setup:']);
-        $job = $this->getMockForAbstractClass(\Magento\Setup\Model\Cron\AbstractJob::class, [], '', false);
+        $job = $this->getMockForAbstractClass(AbstractJob::class, [], '', false);
         $job->expects($this->once())->method('execute')->willThrowException(new \Exception('job failed'));
         $this->queue->expects($this->at(2))->method('popQueuedJob')->willReturn($job);
         $this->status->expects($this->atLeastOnce())->method('toggleUpdateError')->with(true);
@@ -162,7 +168,7 @@ public function testExecute()
         $this->setUpPreliminarySuccess();
         $this->queue->expects($this->at(0))->method('peek')->willReturn(['name' => 'setup:']);
         $this->queue->expects($this->at(1))->method('peek')->willReturn(['name' => 'setup:']);
-        $job = $this->getMockForAbstractClass(\Magento\Setup\Model\Cron\AbstractJob::class, [], '', false);
+        $job = $this->getMockForAbstractClass(AbstractJob::class, [], '', false);
         $job->expects($this->once())->method('execute');
         $this->queue->expects($this->at(2))->method('popQueuedJob')->willReturn($job);
         $this->status->expects($this->never())->method('toggleUpdateError')->with(true);