Review Changes - 18thNov2020

Author: Nihar Ranjan

app/code/Magento/LoginAsCustomerGraphQl/Model/LoginAsCustomer/CreateCustomerToken.php

@@ -16,8 +16,6 @@
 
 /**
  * Create customer token from customer email
- *
- * Class CreateCustomerToken
  */
 class CreateCustomerToken
 {
@@ -32,7 +30,6 @@ class CreateCustomerToken
     private $tokenModelFactory;
 
     /**
-     * CreateCustomerToken constructor.
      * @param TokenFactory $tokenModelFactory
      * @param CustomerFactory $customerFactory
      */

app/code/Magento/LoginAsCustomerGraphQl/Model/Resolver/RequestCustomerToken.php

@@ -42,7 +42,6 @@ class RequestCustomerToken implements ResolverInterface
     private $createCustomerToken;
 
     /**
-     * RequestCustomerToken constructor.
      * @param AuthorizationInterface $authorization
      * @param LoginAsCustomerConfig $config
      * @param CreateCustomerToken $createCustomerToken

app/code/Magento/LoginAsCustomerGraphQl/README.md

@@ -1,51 +1,3 @@
-# Module Magento LoginAsCustomerGraphQl
-
-    ``magento/module-loginascustomergraphql``
-
- - [Main Functionalities](#markdown-header-main-functionalities)
- - [Installation](#markdown-header-installation)
- - [Configuration](#markdown-header-configuration)
- - [Specifications](#markdown-header-specifications)
- - [Attributes](#markdown-header-attributes)
-
-
-## Main Functionalities
-Flexible login as a customer so a merchant or merchant admin can log into an end customer's account to assist them with their account.
-
-## Installation
-\* = in production please use the `--keep-generated` option
-
-### Type 1: Zip file
-
- - Unzip the zip file in `app/code/Magento`
- - Enable the module by running `php bin/magento module:enable Magento_LoginAsCustomerGraphQl`
- - Apply database updates by running `php bin/magento setup:upgrade`\*
- - Flush the cache by running `php bin/magento cache:flush`
-
-### Type 2: Composer
-
- - Make the module available in a composer repository for example:
-    - private repository `repo.magento.com`
-    - public repository `packagist.org`
-    - public github repository as vcs
- - Add the composer repository to the configuration by running `composer config repositories.repo.magento.com composer https://repo.magento.com/`
- - Install the module composer by running `composer require magento/module-loginascustomergraphql`
- - enable the module by running `php bin/magento module:enable Magento_LoginAsCustomerGraphQl`
- - apply database updates by running `php bin/magento setup:upgrade`\*
- - Flush the cache by running `php bin/magento cache:flush`
-
-
-## Configuration
-
-
-
-
-## Specifications
-
-
-
-
-## Attributes
-
-
+# LoginAsCustomerGraphQl
 
+**LoginAsCustomerGraphQl** provides flexible login as a customer so a merchant or merchant admin can log into an end customer's account to assist them with their account.

app/code/Magento/LoginAsCustomerGraphQl/composer.json

@@ -5,7 +5,6 @@
         "php": "~7.3.0||~7.4.0",
         "magento/framework": "*",
         "magento/module-login-as-customer-api": "*",
-        "magento/module-integration": "*",
         "magento/module-store": "*",
         "magento/module-customer": "*",
         "magento/module-catalog-graph-ql": "*"

app/code/Magento/LoginAsCustomerGraphQl/etc/module.xml

@@ -8,10 +8,10 @@
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
 	<module name="Magento_LoginAsCustomerGraphQl">
         <sequence>
-            <module name="Magento_LoginAsCustomer"/>
+            <module name="Magento_LoginAsCustomerApi"/>
             <module name="Magento_Customer"/>
-            <module name="Magento_Authorization"/>
-            <module name="Magento_GraphQl"/>
+            <module name="Magento_Store"/>
+            <module name="Magento_CatalogGraphQl"/>
         </sequence>
     </module>
 </config>

app/code/Magento/LoginAsCustomerGraphQl/etc/schema.graphqls

@@ -6,25 +6,25 @@ type Mutation {
         input: GenerateCustomerTokenAsAdminInput!
     ): GenerateCustomerTokenAsAdminOutput
     @resolver(class: "Magento\\LoginAsCustomerGraphQl\\Model\\Resolver\\RequestCustomerToken")
-    @doc(description: "Request a token using Customer email")
+    @doc(description: "Request a customer token so that an administrator can perform remote shopping assistance")
 }
 
 input GenerateCustomerTokenAsAdminInput {
-    customer_email: String!
+    customer_email: String! @doc(description: "The email address of the customer requesting remote shopping assistance")
 }
 
 type GenerateCustomerTokenAsAdminOutput {
-    customer_token: String!
+    customer_token: String! @doc(description: "The generated customer token")
 }
 
 type Customer {
-    allow_remote_shopping_assistance: Boolean!
+    allow_remote_shopping_assistance: Boolean! @doc(description: "Indicates whether the customer has enabled remote shopping assistance")
 }
 
 input CustomerCreateInput {
-    allow_remote_shopping_assistance: Boolean
+    allow_remote_shopping_assistance: Boolean @doc(description: "Indicates whether the customer has enabled remote shopping assistance")
 }
 
 input CustomerUpdateInput {
-    allow_remote_shopping_assistance: Boolean
+    allow_remote_shopping_assistance: Boolean @doc(description: "Indicates whether the customer has enabled remote shopping assistance")
 }